Clean up legacy ghp-import deploy path and restore FloodMapper logo - #118
Merged
Conversation
Stage 1 moved Pages deployment to actions/upload-pages-artifact + actions/deploy-pages, which publish a build artifact instead of pushing to the gh-pages branch. The old ghp-import path is now dead code: - Drop ghp-import from the docs extra and relock. - Remove the Makefile `publish-docs` target -- it pushed to gh-pages, which is no longer the deployment source. - Delete jupyterbook/requirements.txt, an orphan of the pre-uv pip flow (it also pinned nothing, re-introducing the jupyter-book 2.x trap). - Rewrite jupyterbook/README.md for the current uv + GitHub Actions flow; also refresh the stale PyPI-publish section, which still referenced the removed setup.py, and fix a `bask` -> `bash` typo.
Commit 9616ff6 on the gh-pages branch swapped in the new FloodMapper logo and renamed the landing-page intro to "FloodMapper (also known as ML4Floods)". Those edits were made to the built site only, never to source, so they would be lost now that deploys rebuild from jupyterbook/. - Replace jupyterbook/ml4cc_logo.png with the new logo (516 KB -> 40 KB). - Update the opening sentence of jupyterbook/content/config.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #117 (the Pages-deploy migration). Two independent changes:
Remove the now-redundant ghp-import deploy path (
7fa9670)Since #117, deployment uses
actions/upload-pages-artifact+actions/deploy-pages(artifact-based), so the oldghp-import→gh-pagespath is dead:ghp-importfrom thedocsextra and relock.publish-docsMakefile target.jupyterbook/requirements.txt(orphan of the pre-uv pip flow).jupyterbook/README.mdfor the current uv + Actions flow; also refresh the stale PyPI-publish section (it referenced the removedsetup.py) and fix abask→bashtypo.Restore FloodMapper logo and intro text from gh-pages (
a36e1c8)Commit
9616ff6on thegh-pagesbranch swapped in the new FloodMapper logo and renamed the landing-page intro, but only in built output — never in source. Now that deploys rebuild fromjupyterbook/, these are ported into source:jupyterbook/ml4cc_logo.pngwith the new logo (516 KB → 40 KB).jupyterbook/content/config.md.Verification
Book builds locally with both changes (
jupyter-book1.0.4.post1,build succeeded); the new logo is copied to_build/html/_static/and the FloodMapper text appears in the renderedconfig.html. No repo-settings change needed — Pages is already on "GitHub Actions".