Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two problems that were slowing IDB down a ton:
fn full_render(), which meant that full renders (new file, deleted file) were creating states serially. This happened becauseIndexMap::par_valueis locked behind a feature flag that we at some point stopped enabling, yay for transitive feature flags.Profile captured over the first 1000 images generated by tigercat2000/IconDiffBot2-test#22
Profile overview before:

Profile overview after:

Main difference is that the tokio-runtime-worker thread is no longer pegged at 99% CPU the entire time.