Skip to content

Fix most access to unset attributes in assign_wcs#10177

Draft
emolter wants to merge 1 commit intospacetelescope:mainfrom
emolter:hasattr-bug
Draft

Fix most access to unset attributes in assign_wcs#10177
emolter wants to merge 1 commit intospacetelescope:mainfrom
emolter:hasattr-bug

Conversation

@emolter
Copy link
Collaborator

@emolter emolter commented Jan 22, 2026

Resolves JP-nnnn

This PR addresses ...

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks step-level or public API (as defined in the docs), also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.31%. Comparing base (bbf1e5f) to head (faa0b00).
⚠️ Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
jwst/lib/exposure_types.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10177      +/-   ##
==========================================
+ Coverage   85.98%   86.31%   +0.33%     
==========================================
  Files         368      366       -2     
  Lines       38457    38410      -47     
==========================================
+ Hits        33066    33155      +89     
+ Misses       5391     5255     -136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant