JP-4196: Update NIS_WFSS exptype to expect per-wavelength units in photom ref file#10199
JP-4196: Update NIS_WFSS exptype to expect per-wavelength units in photom ref file#10199emolter wants to merge 15 commits intospacetelescope:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10199 +/- ##
==========================================
- Coverage 85.98% 84.66% -1.33%
==========================================
Files 368 366 -2
Lines 38457 38463 +6
==========================================
- Hits 33066 32563 -503
- Misses 5391 5900 +509 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| # check for regression by hard-coding one value of slit.data | ||
| assert np.isclose(slit.data[5, 60], 20.996877670288086) | ||
| assert np.isclose(slit.data[5, 60], 0.09994397) |
There was a problem hiding this comment.
the mock photom ref file sensitivities are all set to unity for this test, so it stands to reason that the value we are checking would change substantially.
|
@KevinVolkSTScI is still doing some analysis of the new photom output values with this PR, but they're within 1% of the old values so if there's any code issue, it's almost certainly due to some pre-existing issue, not the code changes here. Therefore I'm marking this ready for review now. |
Resolves JP-4196
Closes #10058
This PR updates the
photomandwfss_contamsteps to expect per-wavelength units in NIRISS WFSS photometric reference file data, similar to what is already done for NIRCam.Please note that this requires a coordinated reference file delivery.
https://github.com/spacetelescope/RegressionTests/actions/runs/21487386050
Regression tests are expected to have very large differences for all NIRISS WFSS data downstream of the photom step, and for tests where
wfss_contamis turned on. I'd expect the differences to be much smaller (say, a few percent or less) when pointed to the new ref file.These tests are useful to show that only the products we'd expect to change have changed.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files