JP-4228: Update metadata attributes to not assume implicit setting to default on access#10237
Draft
emolter wants to merge 5 commits intospacetelescope:mainfrom
Draft
JP-4228: Update metadata attributes to not assume implicit setting to default on access#10237emolter wants to merge 5 commits intospacetelescope:mainfrom
emolter wants to merge 5 commits intospacetelescope:mainfrom
Conversation
5 tasks
Collaborator
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10237 +/- ##
==========================================
+ Coverage 85.98% 86.53% +0.55%
==========================================
Files 368 366 -2
Lines 38457 38455 -2
==========================================
+ Hits 33066 33277 +211
+ Misses 5391 5178 -213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to JP-4228
This PR addresses all instances where metadata attributes were assumed to be set to a schema default on access. This change is needed for spacetelescope/stdatamodels#662 but does not break anything so can be handled separately.
There are very few metadata attributes with schema-defined defaults in stdatamodels.
It turns out that this behavior was only meaningfully used by the pipeline for the
lamp_mode,asn.exptype, andwcsinfo.s_regionattributes.TODO: there are two explicit attribute sets in combine_1d tests that should be here too
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files