JP-4091 adding MIRI WFSS background subtraction#10241
Draft
jemorrison wants to merge 2 commits intospacetelescope:mainfrom
Draft
JP-4091 adding MIRI WFSS background subtraction#10241jemorrison wants to merge 2 commits intospacetelescope:mainfrom
jemorrison wants to merge 2 commits intospacetelescope:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10241 +/- ##
==========================================
+ Coverage 85.98% 86.51% +0.53%
==========================================
Files 368 366 -2
Lines 38457 38458 +1
==========================================
+ Hits 33066 33271 +205
+ Misses 5391 5187 -204 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress.
Resolves JP-4091
This PR adds the hooks in background_step to subtract a MIRI WFSS reference file.
The current MIRI WFSS background reference file in CRDS needs to be updated.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files