Skip to content

JP-4091 adding MIRI WFSS background subtraction#10241

Draft
jemorrison wants to merge 2 commits intospacetelescope:mainfrom
jemorrison:new_miri_wfss
Draft

JP-4091 adding MIRI WFSS background subtraction#10241
jemorrison wants to merge 2 commits intospacetelescope:mainfrom
jemorrison:new_miri_wfss

Conversation

@jemorrison
Copy link
Collaborator

@jemorrison jemorrison commented Feb 9, 2026

This is a work in progress.

Resolves JP-4091

This PR adds the hooks in background_step to subtract a MIRI WFSS reference file.
The current MIRI WFSS background reference file in CRDS needs to be updated.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks step-level or public API (as defined in the docs), also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@jemorrison jemorrison requested a review from a team February 9, 2026 17:27
@jemorrison jemorrison marked this pull request as draft February 9, 2026 17:33
@jemorrison jemorrison changed the title adding miri background subtraction for WFSS JP-4091 adding MIRI WFSS background subtraction Feb 9, 2026
@jemorrison jemorrison added this to the Build 12.3 milestone Feb 9, 2026
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.51%. Comparing base (bbf1e5f) to head (c85d7ff).
⚠️ Report is 67 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10241      +/-   ##
==========================================
+ Coverage   85.98%   86.51%   +0.53%     
==========================================
  Files         368      366       -2     
  Lines       38457    38458       +1     
==========================================
+ Hits        33066    33271     +205     
+ Misses       5391     5187     -204     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant