Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9788 +/- ##
==========================================
- Coverage 82.54% 82.54% -0.01%
==========================================
Files 366 366
Lines 37248 37246 -2
==========================================
- Hits 30748 30745 -3
- Misses 6500 6501 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Does anaconda allow uploading a wheel with a "git+*" dependency? |
|
I don't see why not. Installing the wheels is another story though. Why are we pinning to |
Thanks, I asked because pypi does not allow these.
If installing will still trigger building stcal from source what benefit is there in uploading a nightly for jwst?
Often PRs with (let's say) stcal and jwst are paired. This is typically handled by having the jwst requirement point to stcal main (since there is often no released version that is compatible). For your local installation perhaps it's worth trying |
Not having to build the C stuff from this repo, maybe. I really don't think we should pin to If you really want to pair up stcal so specifically, maybe a git submodule is what you want. |
Thanks. Is that the goal here? Is there a ticket or conversation discussing this? |
Tyler said there is a ticket at tag-up, so maybe he could clarify. This PR started out as an "academic exercise." |
|
The general idea here is good - SDP used to pull yml environment files from Artifactory to do ~weekly tests of SDP+CAL integration. That said, I don't believe we do (or want to do) any uploads to conda; we've moved away from conda channels generally, and it'd probably be simplest to upload wheels/ymls to Artifactory instead. This would mimic behavior that Roman has started to use for their multicomponent nightly testing architecture, which queries Artifactory for dev environment files. DMD/SDP is not yet looking to implement this, though. If you'd like, feel free to edit the PR to upload to Artifactory. I'll move the PR to draft until we have a use case for the wheels. |
|
I do agree with @pllim that we should ideally be moving away from defining |
|
It is hosted at anaconda but it is not a conda package. You would install it like this: |
|
You can see example uploads from synphot here: https://pypi.anaconda.org/stsci/simple/synphot |
|
We need to deliver entire environments for "nightly" testing to SDP. Is the current RegressionTests scheduled action write out the files to Artifactory or was this dropped with the change to Jenkins? |
|
If you mean https://github.com/spacetelescope/RegressionTests/blob/main/.github/workflows/jwst.yml , I see uploads for nightly test results which I don't think is the same as nightly builds. |
|
Anyways... if you don't like this proposal, feel free to close without merge. I opened a separate issue about |
That would naturally exclude non-staff members from being able to use them, so not my fav option, but I don't make the call here. Also, Artifactory stuff is beyond me, so I'll leave that to someone else if you want to pursue this route instead. |
This PR adds nightly dev wheels to enable user to install recent enough dev version without building from source. These should be the same wheels combo we would release later.
Cannot really test until after merge. 🎲
No need to run RT.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files