JP-4169: Allow source splitting across chunks in wfss_contam#9956
Draft
emolter wants to merge 3 commits intospacetelescope:mainfrom
Draft
JP-4169: Allow source splitting across chunks in wfss_contam#9956emolter wants to merge 3 commits intospacetelescope:mainfrom
emolter wants to merge 3 commits intospacetelescope:mainfrom
Conversation
10 tasks
Collaborator
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9956 +/- ##
==========================================
+ Coverage 85.98% 86.52% +0.54%
==========================================
Files 368 366 -2
Lines 38457 38479 +22
==========================================
+ Hits 33066 33294 +228
+ Misses 5391 5185 -206 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JP-4169
Closes #9955
This PR allows large sources to be split across chunks of size
max_pixels_per_chunk, and also enforces that all chunks except the last chunk be of exactly sizemax_pixels_per_chunk.Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files