Skip to content

remove unused dependencies#9999

Merged
braingram merged 1 commit intospacetelescope:mainfrom
braingram:rm_imagestats
Nov 7, 2025
Merged

remove unused dependencies#9999
braingram merged 1 commit intospacetelescope:mainfrom
braingram:rm_imagestats

Conversation

@braingram
Copy link
Collaborator

@braingram braingram commented Nov 6, 2025

wiimatch is unused post #9486
stsci.imagestats is used by stcal and should be a dependency there: spacetelescope/stcal#433

This won't quite work until spacetelescope/stcal#433 is merged. However since tweakwcs also incorrectly listed imagestats as a dependency (spacetelescope/tweakwcs#236) we still pull this in.

Regression tests: https://github.com/spacetelescope/RegressionTests/actions/runs/19149033220
as expect, still show stsci.imagestats and show that wiimatch is not installed

I suggest that we merge this PR at the same time as the stcal one. The reasoning is the oldestdeps job here may start complaining when the stcal PR is merged since the lower pin in stcal (1.8.3) is higher than the current jwst lower pin (1.6.3).

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.52%. Comparing base (38c180a) to head (717fd5e).
⚠️ Report is 174 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9999      +/-   ##
==========================================
+ Coverage   85.45%   85.52%   +0.07%     
==========================================
  Files         366      366              
  Lines       37845    38029     +184     
==========================================
+ Hits        32341    32526     +185     
+ Misses       5504     5503       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@braingram braingram marked this pull request as ready for review November 6, 2025 21:13
@braingram braingram requested a review from a team as a code owner November 6, 2025 21:13
Copy link
Collaborator

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like cleanups like this. Thanks!

@braingram braingram enabled auto-merge November 7, 2025 15:56
@braingram
Copy link
Collaborator Author

I restarted the CI now that spacetelescope/stcal#433 is merged and set this PR to automerge.

@braingram braingram merged commit 9927320 into spacetelescope:main Nov 7, 2025
39 of 40 checks passed
@braingram braingram deleted the rm_imagestats branch November 7, 2025 16:56
@braingram braingram restored the rm_imagestats branch November 7, 2025 19:40
@braingram braingram deleted the rm_imagestats branch November 7, 2025 19:40
@nden nden mentioned this pull request Nov 7, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants