-
Notifications
You must be signed in to change notification settings - Fork 33
Fix the extras tests #792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the extras tests #792
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
==========================================
+ Coverage 85.87% 86.34% +0.46%
==========================================
Files 14 15 +1
Lines 1069 1135 +66
==========================================
+ Hits 918 980 +62
- Misses 151 155 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
this looks good to me, except for the |
zacharyburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when tests pass
Yes that is the failing error that this PR is fixing. |
c5056b5 to
09e579f
Compare
09e579f to
30f786c
Compare
PaulHuwe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves RAD-nnnn
Closes #
The
extra testshave been failing for awhile now, e.g. https://github.com/spacetelescope/rad/actions/runs/20701504615. The error indicated that there was something wrong with theasdf-astropydependency. This PR updates theasdf-astropymin version until those tests were successful.Tasks
radtests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").roman_datamodelsutilities and tests.News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change