Skip to content

Conversation

@WilliamJamieson
Copy link
Collaborator

Resolves RAD-nnnn

Closes #

The extra tests have been failing for awhile now, e.g. https://github.com/spacetelescope/rad/actions/runs/20701504615. The error indicated that there was something wrong with the asdf-astropy dependency. This PR updates the asdf-astropy min version until those tests were successful.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.34%. Comparing base (6ab0be9) to head (30f786c).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #792      +/-   ##
==========================================
+ Coverage   85.87%   86.34%   +0.46%     
==========================================
  Files          14       15       +1     
  Lines        1069     1135      +66     
==========================================
+ Hits          918      980      +62     
- Misses        151      155       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zacharyburnett
Copy link
Collaborator

zacharyburnett commented Jan 5, 2026

this looks good to me, except for the oldestdeps test:
https://github.com/spacetelescope/rad/actions/runs/20701504615/job/59424450939#step:10:106

E   asdf.exceptions.AsdfWarning: asdf.resource_mappings plugin from package asdf-astropy==0.5.0 failed to load:

Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tests pass

@WilliamJamieson
Copy link
Collaborator Author

this looks good to me, except for the oldestdeps test: spacetelescope/rad/actions/runs/20701504615/job/59424450939#step:10:106

E   asdf.exceptions.AsdfWarning: asdf.resource_mappings plugin from package asdf-astropy==0.5.0 failed to load:

Yes that is the failing error that this PR is fixing.

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson merged commit 529be01 into spacetelescope:main Jan 7, 2026
25 checks passed
@WilliamJamieson WilliamJamieson deleted the fix_extras branch January 7, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants