Skip to content

Conversation

@WilliamJamieson
Copy link
Collaborator

In PR #789 a latest file AND its symlink were removed, which exposed a bug in the archive comparison script. This is an oversight as for the SOC schemas never result in a file missing form the src/rad/resources directory as we are versioning those schemas. However, the SSC schemas are not versioned so when a file/symlink was removed from src/rad/resources ASDF fails to fully resolve the old state of RAD.

This PR fixes this by also targeting the changes to src/rad/resources.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.34%. Comparing base (6ab0be9) to head (5c6dfc0).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
+ Coverage   85.87%   86.34%   +0.46%     
==========================================
  Files          14       15       +1     
  Lines        1069     1135      +66     
==========================================
+ Hits          918      980      +62     
- Misses        151      155       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson merged commit dcce323 into spacetelescope:main Jan 8, 2026
20 of 21 checks passed
@WilliamJamieson WilliamJamieson deleted the bugfix/archive_delete_file branch January 8, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants