[SCSB-223] align dependencies with explicit imports#626
[SCSB-223] align dependencies with explicit imports#626zacharyburnett wants to merge 1 commit intospacetelescope:mainfrom
Conversation
|
@braingram just making sure, |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
==========================================
- Coverage 97.56% 94.55% -3.01%
==========================================
Files 30 26 -4
Lines 2788 2681 -107
==========================================
- Hits 2720 2535 -185
- Misses 68 146 +78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "astropy >=6.0.0", | ||
| # "rad >=0.29.1", | ||
| "rad @ git+https://github.com/spacetelescope/rad.git", | ||
| "asdf-standard >=1.1.0", |
There was a problem hiding this comment.
I think we can remove this one since rdm has no schemas.
Since |
48b06b0 to
c16de13
Compare
|
for EDIT: |
c16de13 to
60d2055
Compare
Why is oldestdeps trying to install an old test dependency? Under what condition do we want to be using an old pytest plugin? |
60d2055 to
a6144da
Compare
a6144da to
2f32cd2
Compare
|
running regression test here: https://github.com/spacetelescope/RegressionTests/actions/runs/22000264418 |
Resolves SCSB-223
used
valimdepto find unimported dependencies and undepended imports:removedasdf-astropypyyamlTasks
roman_datamodelstests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change