Skip to content

Add PSF-matching to multiband catalogs#2051

Open
larrybradley wants to merge 23 commits intospacetelescope:mainfrom
larrybradley:psf-matching
Open

Add PSF-matching to multiband catalogs#2051
larrybradley wants to merge 23 commits intospacetelescope:mainfrom
larrybradley:psf-matching

Conversation

@larrybradley
Copy link
Member

Resolves RCAL-nnnn

Closes #

This PR adds PSF-matching to multiband catalogs.

I also refactored MultibandCatalogStep to break up the large process method to make it more maintainable.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly
news fragment change types...
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change
  • changes/<PR#>.docs.rst
  • changes/<PR#>.stpipe.rst
  • changes/<PR#>.associations.rst
  • changes/<PR#>.scripts.rst
  • changes/<PR#>.mosaic_pipeline.rst
  • changes/<PR#>.skycell.rst

steps

  • changes/<PR#>.dq_init.rst
  • changes/<PR#>.saturation.rst
  • changes/<PR#>.refpix.rst
  • changes/<PR#>.linearity.rst
  • changes/<PR#>.dark_current.rst
  • changes/<PR#>.jump_detection.rst
  • changes/<PR#>.ramp_fitting.rst
  • changes/<PR#>.assign_wcs.rst
  • changes/<PR#>.flatfield.rst
  • changes/<PR#>.photom.rst
  • changes/<PR#>.flux.rst
  • changes/<PR#>.source_detection.rst
  • changes/<PR#>.tweakreg.rst
  • changes/<PR#>.skymatch.rst
  • changes/<PR#>.outlier_detection.rst
  • changes/<PR#>.resample.rst
  • changes/<PR#>.source_catalog.rst

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 95.56136% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.14%. Comparing base (3fcc141) to head (e935491).

Files with missing lines Patch % Lines
romancal/source_catalog/psf_matching.py 92.85% 6 Missing ⚠️
romancal/source_catalog/source_catalog.py 88.67% 6 Missing ⚠️
romancal/multiband_catalog/multiband_catalog.py 97.36% 3 Missing ⚠️
romancal/multiband_catalog/catalog_generator.py 98.61% 1 Missing ⚠️
romancal/multiband_catalog/metadata.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2051      +/-   ##
==========================================
+ Coverage   79.45%   80.14%   +0.69%     
==========================================
  Files         139      142       +3     
  Lines        8635     8910     +275     
==========================================
+ Hits         6861     7141     +280     
+ Misses       1774     1769       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@larrybradley larrybradley marked this pull request as draft November 12, 2025 17:41
@larrybradley larrybradley removed this from the 26Q1_B20 milestone Nov 12, 2025
@larrybradley larrybradley marked this pull request as ready for review November 26, 2025 20:41
@mairanteodoro mairanteodoro self-requested a review February 10, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants