add back-compatibility alias for get_webbpsf_data_path#964
Merged
BradleySappington merged 1 commit intospacetelescope:developfrom Feb 20, 2025
Merged
Conversation
BradleySappington
approved these changes
Feb 20, 2025
Collaborator
BradleySappington
left a comment
BradleySappington
left a comment
There was a problem hiding this comment.
Good solution, keeps everything consolidated and still running the same code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whoops, looks like one function got missed or overlooked accidentally in the repo migration: The function
webbpsf.utils.get_webbpsf_data_path()doesn't simply work via thesys.modulesredirect, because the function name changed toget_stpsf_data_path(). The lack of this function breaks at least some existing legacy code, in the webbpsf_ext repo.This PR addresses that by manually adding an alias for that to the
stpsfnamespace, such that calls towebbpsf.utils.get_webbpsf_data_path()will correctly invokestpsf.utils.get_stpsf_data_path().