Updates to Qt6 related packages #192 #2058
Conversation
| # OpenGL headers are required at build time | ||
| # GL, provided by the Qt application is required at runtime. | ||
| # Do not include GL in the "link" rpaths as GL may be loaded at runtime | ||
| # and differ from the GL that provided the headers. | ||
| depends_on("gl", when="+opengl", type=("build", "link")) | ||
| depends_on("glu", when="+opengl", type=("build", "link")) |
There was a problem hiding this comment.
I don't understand this.
Do not include GL in the "link" rpaths as GL may be loaded at runtime
but:
depends_on("gl", when="+opengl", type=("build", "link"))which is exactly the same as the previous:
depends_on("gl", when="+opengl")with the dependencies made explicit. It's also of link type, which seems to contradict the comment. 🤔
There was a problem hiding this comment.
It looks like some of the components do in fact link GL...These changes have been going on since before May, so it is possible the comment went stale.
alalazo
left a comment
alalazo
left a comment
There was a problem hiding this comment.
There are legitimate failures in pipelines:
This PR needs #2057 which fixes issues with FindOpenGL |
| depends_on("gl", when="+opengl", type="build") | ||
| depends_on("glu", when="+opengl", type="build") |
There was a problem hiding this comment.
Can you explain this? I thought the fix was to also link? Are we trying to enable LD_LIBRARY_PATH with Spack?
There was a problem hiding this comment.
Hm, I think you are right, I don't remember why the link got dropped anymore.
kwryankrattiger
force-pushed
the
qt_updates_from_192
branch
from
31f0c1e to
025140e
Compare
kwryankrattiger
force-pushed
the
qt_updates_from_192
branch
from
025140e to
bc8124d
Compare
3 participants
Extracted Qt6 updates from #192