Skip to content

Logic to install plugins for cmake netcdf-c builds #2887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vanderwb wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Logic to install plugins for cmake netcdf-c builds #2887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions repos/spack_repo/builtin/packages/netcdf_c/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,16 @@ def cmake_args(self):
base_cmake_args.append(self.define(nc + "FIND_SHARED_LIBS", True))
else:
base_cmake_args.append(self.define(nc + "FIND_SHARED_LIBS", False))

if self.spec.satisfies("@4.9.0:+shared"):
# The plugins are not built when the shared libraries are disabled:
if self.spec.satisfies("@4.9.3:"):
# This toggle is not defined in the top-level CMake parameters but is still
# used by the plugin config; so we work around this bug for now
base_cmake_args.append(self.define("ENABLE_PLUGIN_INSTALL", True))
base_cmake_args.append(self.define("NETCDF_WITH_PLUGIN_DIR", self.prefix.plugins))
else:
base_cmake_args.append(self.define("PLUGIN_INSTALL_DIR", self.prefix.plugins))
return base_cmake_args

@run_after("install")
Expand Down
Loading