Skip to content

qgis: add 3.44#3622

Merged
adamjstewart merged 10 commits intospack:developfrom
Chrismarsh:package-fix/qgis
Mar 11, 2026
Merged

qgis: add 3.44#3622
adamjstewart merged 10 commits intospack:developfrom
Chrismarsh:package-fix/qgis

Conversation

@Chrismarsh
Copy link
Contributor

  • adds the last of the qgis 3.x line, qgis@3.44
  • updated patch for py sip due to changed layout of toml file
  • adds a new version of py-psycopg2 to allow for python@3.14 support with qgis
  • bounds the libspatialindex version due to an upstream API change that broke qgis

@Chrismarsh
Copy link
Contributor Author

@adamjstewart @Sinan81

@Chrismarsh
Copy link
Contributor Author

@spackbot fix style

@spackbot-app
Copy link

spackbot-app bot commented Mar 2, 2026

Let me see if I can fix that for you!

@spackbot-app
Copy link

spackbot-app bot commented Mar 2, 2026

I was able to run spack style --fix for you!

spack style --fix
repos/spack_repo/builtin/packages/acts/package.py
repos/spack_repo/builtin/packages/cargo_c/package.py
repos/spack_repo/builtin/packages/composable_kernel/package.py
repos/spack_repo/builtin/packages/exodusii/package.py
repos/spack_repo/builtin/packages/file/package.py
repos/spack_repo/builtin/packages/garfieldpp/package.py
repos/spack_repo/builtin/packages/ginkgo/package.py
repos/spack_repo/builtin/packages/git/package.py
repos/spack_repo/builtin/packages/hipdnn/package.py
repos/spack_repo/builtin/packages/hwloc/package.py
repos/spack_repo/builtin/packages/libcxi/package.py
repos/spack_repo/builtin/packages/libmesh/package.py
repos/spack_repo/builtin/packages/libmetatomic_torch/package.py
repos/spack_repo/builtin/packages/libxcrypt/package.py
repos/spack_repo/builtin/packages/libxslt/package.py
repos/spack_repo/builtin/packages/linaro_forge/package.py
repos/spack_repo/builtin/packages/llvm_amdgpu/package.py
repos/spack_repo/builtin/packages/lmod/package.py
repos/spack_repo/builtin/packages/lua_luafilesystem/package.py
repos/spack_repo/builtin/packages/lua_luaposix/package.py
repos/spack_repo/builtin/packages/memtailor/package.py
repos/spack_repo/builtin/packages/openmpi/package.py
repos/spack_repo/builtin/packages/openvdb/package.py
repos/spack_repo/builtin/packages/pmix/package.py
repos/spack_repo/builtin/packages/procps/package.py
repos/spack_repo/builtin/packages/proj/package.py
repos/spack_repo/builtin/packages/prrte/package.py
repos/spack_repo/builtin/packages/psblas/package.py
repos/spack_repo/builtin/packages/py_beartype/package.py
repos/spack_repo/builtin/packages/py_biopython/package.py
repos/spack_repo/builtin/packages/py_gevent/package.py
repos/spack_repo/builtin/packages/py_llvmlite/package.py
repos/spack_repo/builtin/packages/py_lxml/package.py
repos/spack_repo/builtin/packages/py_matplotlib/package.py
repos/spack_repo/builtin/packages/py_metatomic_torch/package.py
repos/spack_repo/builtin/packages/py_petsc4py/package.py
repos/spack_repo/builtin/packages/py_protobuf/package.py
repos/spack_repo/builtin/packages/py_psycopg2/package.py
repos/spack_repo/builtin/packages/py_setuptools/package.py
repos/spack_repo/builtin/packages/py_setuptools_scm/package.py
repos/spack_repo/builtin/packages/py_textx/package.py
repos/spack_repo/builtin/packages/py_typer/package.py
repos/spack_repo/builtin/packages/py_tzlocal/package.py
repos/spack_repo/builtin/packages/py_vesin/package.py
repos/spack_repo/builtin/packages/qgis/package.py
repos/spack_repo/builtin/packages/qt_base/package.py
repos/spack_repo/builtin/packages/rdkit/package.py
repos/spack_repo/builtin/packages/root/package.py
repos/spack_repo/builtin/packages/vecmem/package.py
repos/spack_repo/builtin/packages/verilator/package.py
repos/spack_repo/builtin/packages/xz/package.py
repos/spack_repo/builtin/packages/zlib_ng/package.py
�[1;34m==> �[0mrunning flake8
repos/spack_repo/builtin/packages/qgis/package.py:10: [F401] 're' imported but unused
repos/spack_repo/builtin/packages/qgis/package.py:12: [E302] expected 2 blank lines, found 1
repos/spack_repo/builtin/packages/qgis/package.py:174: [E303] too many blank lines (2)
repos/spack_repo/builtin/packages/qgis/package.py:239: [E501] line too long (123 > 99 characters)
repos/spack_repo/builtin/packages/qgis/package.py:240: [E501] line too long (116 > 99 characters)
�[1;34m==> �[0mrunning isort
Fixing /tmp/tmpj0q3yukm/fork/repos/spack_repo/builtin/packages/qgis/package.py
�[1;34m==> �[0mrunning black
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

@Chrismarsh
Copy link
Contributor Author

@spackbot fix style

@spackbot-app
Copy link

spackbot-app bot commented Mar 2, 2026

Let me see if I can fix that for you!

@spackbot-app
Copy link

spackbot-app bot commented Mar 2, 2026

I was able to run spack style --fix for you!

spack style --fix
repos/spack_repo/builtin/packages/acts/package.py
repos/spack_repo/builtin/packages/cargo_c/package.py
repos/spack_repo/builtin/packages/composable_kernel/package.py
repos/spack_repo/builtin/packages/exodusii/package.py
repos/spack_repo/builtin/packages/file/package.py
repos/spack_repo/builtin/packages/garfieldpp/package.py
repos/spack_repo/builtin/packages/ginkgo/package.py
repos/spack_repo/builtin/packages/git/package.py
repos/spack_repo/builtin/packages/hipdnn/package.py
repos/spack_repo/builtin/packages/hwloc/package.py
repos/spack_repo/builtin/packages/icarus/package.py
repos/spack_repo/builtin/packages/libcxi/package.py
repos/spack_repo/builtin/packages/libmesh/package.py
repos/spack_repo/builtin/packages/libmetatomic_torch/package.py
repos/spack_repo/builtin/packages/libxcrypt/package.py
repos/spack_repo/builtin/packages/libxslt/package.py
repos/spack_repo/builtin/packages/linaro_forge/package.py
repos/spack_repo/builtin/packages/llvm_amdgpu/package.py
repos/spack_repo/builtin/packages/lmod/package.py
repos/spack_repo/builtin/packages/lua_luafilesystem/package.py
repos/spack_repo/builtin/packages/lua_luaposix/package.py
repos/spack_repo/builtin/packages/memtailor/package.py
repos/spack_repo/builtin/packages/openfpgaloader/package.py
repos/spack_repo/builtin/packages/openmpi/package.py
repos/spack_repo/builtin/packages/openvdb/package.py
repos/spack_repo/builtin/packages/pmix/package.py
repos/spack_repo/builtin/packages/procps/package.py
repos/spack_repo/builtin/packages/proj/package.py
repos/spack_repo/builtin/packages/prrte/package.py
repos/spack_repo/builtin/packages/psblas/package.py
repos/spack_repo/builtin/packages/py_beartype/package.py
repos/spack_repo/builtin/packages/py_biopython/package.py
repos/spack_repo/builtin/packages/py_gevent/package.py
repos/spack_repo/builtin/packages/py_llvmlite/package.py
repos/spack_repo/builtin/packages/py_lxml/package.py
repos/spack_repo/builtin/packages/py_matplotlib/package.py
repos/spack_repo/builtin/packages/py_metatomic_torch/package.py
repos/spack_repo/builtin/packages/py_petsc4py/package.py
repos/spack_repo/builtin/packages/py_protobuf/package.py
repos/spack_repo/builtin/packages/py_psycopg2/package.py
repos/spack_repo/builtin/packages/py_setuptools/package.py
repos/spack_repo/builtin/packages/py_setuptools_scm/package.py
repos/spack_repo/builtin/packages/py_textx/package.py
repos/spack_repo/builtin/packages/py_typer/package.py
repos/spack_repo/builtin/packages/py_tzlocal/package.py
repos/spack_repo/builtin/packages/py_vesin/package.py
repos/spack_repo/builtin/packages/qgis/package.py
repos/spack_repo/builtin/packages/qt_base/package.py
repos/spack_repo/builtin/packages/rdkit/package.py
repos/spack_repo/builtin/packages/root/package.py
repos/spack_repo/builtin/packages/vecmem/package.py
repos/spack_repo/builtin/packages/verilator/package.py
repos/spack_repo/builtin/packages/xz/package.py
repos/spack_repo/builtin/packages/zlib_ng/package.py
�[1;34m==> �[0mrunning flake8
repos/spack_repo/builtin/packages/qgis/package.py:238: [W291] trailing whitespace
repos/spack_repo/builtin/packages/qgis/package.py:239: [W291] trailing whitespace
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

Copy link
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New patch syntax is rather complex, I'm hoping we can either:

  1. overwrite the entire file every time,
  2. use filter_file to replace existing lines, and/or
  3. use if self.spec.satisfies("@X.Y:Z"): to make things conditional on version

Honestly, @Sinan81 wrote most of this file, so I'm hoping he can provide a more useful review.

@Sinan81
Copy link
Contributor

Sinan81 commented Mar 3, 2026

will provide a review very soon.

@Sinan81
Copy link
Contributor

Sinan81 commented Mar 6, 2026

New patch syntax is rather complex, I'm hoping we can either:

  1. overwrite the entire file every time,
  2. use filter_file to replace existing lines, and/or
  3. use if self.spec.satisfies("@X.Y:Z"): to make things conditional on version

Honestly, @Sinan81 wrote most of this file, so I'm hoping he can provide a more useful review.

The current logic seems fine to me. I don't find it convoluted.

@Sinan81
Copy link
Contributor

Sinan81 commented Mar 6, 2026

Built default version 3.40 and also 3.44 from scratch. looks good. will approve right after the above comment is addressed.

@Chrismarsh
Copy link
Contributor Author

One weird thing was that spack wouldn't find a new version until I updated the url. But the url scheme hasn't changed (as far as I could tell??), so this isn't a case where url_for_version is required. Any ideas?

@Sinan81
Copy link
Contributor

Sinan81 commented Mar 6, 2026

One weird thing was that spack wouldn't find a new version until I updated the url. But the url scheme hasn't changed (as far as I could tell??), so this isn't a case where url_for_version is required. Any ideas?

no idea. Definitely, there's something weird going on. I did a test where I restored original url statement, and tried installing version 3.44.8 (yep, it's released half a day ago lol).
initially, spack install ... just hung, Then I tried again with debug option. it worked fine. Then I cancelled the install and tried again, twice, where spack couldn't fetch the file from qgis downloads webpage. This could simply be a glitch with qgis webpage.

We can keep the url statement as it is, and merge.

@spackbot-triage spackbot-triage bot requested a review from Sinan81 March 9, 2026 17:02
@Chrismarsh
Copy link
Contributor Author

@Sinan81, sorry I just invalided your review as I added a comment to describe the url behaviour. @haampie pointed out to me on Slack that it is because qgis uses a json to list the urls which the checksum crawler won't discover.

@Chrismarsh
Copy link
Contributor Author

It looks like the just-added 3.44.8 is a LTR. Given this package prefers the LTR releases, I think we should add 3.44.8 to this PR (kinda while we are here). So I will do that

@Chrismarsh
Copy link
Contributor Author

Chrismarsh commented Mar 9, 2026

Well this isn't clear to me at all:

@Sinan81
Copy link
Contributor

Sinan81 commented Mar 10, 2026

yes, it's pretty confusing. as far as I can tell 3.44.8 is an LTR. I found the following explanation

In the first four months after its release, a new LTR is also the current LR. In this phase, the new LTR doesn’t replace the previous LTR in the LTR repositories. This happens as soon as a new LR is released.

in https://qgis.org/resources/roadmap/

@Sinan81
Copy link
Contributor

Sinan81 commented Mar 10, 2026

so maybe it's fine to have 3.44.8 listed as the preferred=True in spack until 3.44.12 is released?

by now, I'm convinced that 3.44.8 is an LTR. please go ahead and make it prefferred.

@Sinan81
Copy link
Contributor

Sinan81 commented Mar 10, 2026

Could we also add a version constraint for proj like:

depends_on("proj@:9.5", when="@3.34.5:3.34.15")

only tested this on 3.34.15 but I'm sure older versions will fail to build with proj@9.6:

@Chrismarsh Chrismarsh requested a review from Sinan81 March 10, 2026 14:53
@Sinan81
Copy link
Contributor

Sinan81 commented Mar 10, 2026

@spackbot fix style

@spackbot-app
Copy link

spackbot-app bot commented Mar 10, 2026

Let me see if I can fix that for you!

@spackbot-app
Copy link

spackbot-app bot commented Mar 10, 2026

I was able to run spack style --fix for you!

spack style --fix
.ci/gitlab/scripts/common/noop_job.py
.github/workflows/bin/spack-labeler.py
.github/workflows/bin/spack-reviewers.py
repos/spack_repo/builtin/build_systems/cached_cmake.py
repos/spack_repo/builtin/packages/acts/package.py
repos/spack_repo/builtin/packages/acts_algebra_plugins/package.py
repos/spack_repo/builtin/packages/adios2/package.py
repos/spack_repo/builtin/packages/amrex/package.py
repos/spack_repo/builtin/packages/aocl_dlp/package.py
repos/spack_repo/builtin/packages/arkouda/package.py
repos/spack_repo/builtin/packages/armpl_gcc/package.py
repos/spack_repo/builtin/packages/babl/package.py
repos/spack_repo/builtin/packages/bazel/package.py
repos/spack_repo/builtin/packages/bmi/package.py
repos/spack_repo/builtin/packages/busybox/package.py
repos/spack_repo/builtin/packages/cairo/package.py
repos/spack_repo/builtin/packages/cantera/package.py
repos/spack_repo/builtin/packages/cargo_c/package.py
repos/spack_repo/builtin/packages/cassini_headers/package.py
repos/spack_repo/builtin/packages/clhep/package.py
repos/spack_repo/builtin/packages/clingo/package.py
repos/spack_repo/builtin/packages/composable_kernel/package.py
repos/spack_repo/builtin/packages/cosma/package.py
repos/spack_repo/builtin/packages/cxi_driver/package.py
repos/spack_repo/builtin/packages/dd4hep/package.py
repos/spack_repo/builtin/packages/detray/package.py
repos/spack_repo/builtin/packages/draco/package.py
repos/spack_repo/builtin/packages/duckdb/package.py
repos/spack_repo/builtin/packages/dust/package.py
repos/spack_repo/builtin/packages/eigen/package.py
repos/spack_repo/builtin/packages/exiv2/package.py
repos/spack_repo/builtin/packages/exodusii/package.py
repos/spack_repo/builtin/packages/fargparse/package.py
repos/spack_repo/builtin/packages/fenics_basix/package.py
repos/spack_repo/builtin/packages/fenics_dolfinx/package.py
repos/spack_repo/builtin/packages/fenics_ufcx/package.py
repos/spack_repo/builtin/packages/file/package.py
repos/spack_repo/builtin/packages/garfieldpp/package.py
repos/spack_repo/builtin/packages/gcc/package.py
repos/spack_repo/builtin/packages/geant4/package.py
repos/spack_repo/builtin/packages/gftl/package.py
repos/spack_repo/builtin/packages/gftl_shared/package.py
repos/spack_repo/builtin/packages/ginkgo/package.py
repos/spack_repo/builtin/packages/git/package.py
repos/spack_repo/builtin/packages/glib/package.py
repos/spack_repo/builtin/packages/gnupg/package.py
repos/spack_repo/builtin/packages/gobject_introspection/package.py
repos/spack_repo/builtin/packages/gocryptfs/package.py
repos/spack_repo/builtin/packages/graphlib/package.py
repos/spack_repo/builtin/packages/green_mbpt/package.py
repos/spack_repo/builtin/packages/hdf_eos2/package.py
repos/spack_repo/builtin/packages/hipdnn/package.py
repos/spack_repo/builtin/packages/hwloc/package.py
repos/spack_repo/builtin/packages/icarus/package.py
repos/spack_repo/builtin/packages/knem/package.py
repos/spack_repo/builtin/packages/launchmon/package.py
repos/spack_repo/builtin/packages/lazygit/package.py
repos/spack_repo/builtin/packages/libcxi/package.py
repos/spack_repo/builtin/packages/libgpiod/package.py
repos/spack_repo/builtin/packages/libjpeg/package.py
repos/spack_repo/builtin/packages/libmesh/package.py
repos/spack_repo/builtin/packages/libmetatomic_torch/package.py
repos/spack_repo/builtin/packages/libpressio/package.py
repos/spack_repo/builtin/packages/libproxy/package.py
repos/spack_repo/builtin/packages/librdkafka/package.py
repos/spack_repo/builtin/packages/libxcrypt/package.py
repos/spack_repo/builtin/packages/libxext/package.py
repos/spack_repo/builtin/packages/libxslt/package.py
repos/spack_repo/builtin/packages/likwid/package.py
repos/spack_repo/builtin/packages/linaro_forge/package.py
repos/spack_repo/builtin/packages/llvm/package.py
repos/spack_repo/builtin/packages/llvm_amdgpu/package.py
repos/spack_repo/builtin/packages/lmod/package.py
repos/spack_repo/builtin/packages/lua_luafilesystem/package.py
repos/spack_repo/builtin/packages/lua_luaposix/package.py
repos/spack_repo/builtin/packages/magma/package.py
repos/spack_repo/builtin/packages/memcached/package.py
repos/spack_repo/builtin/packages/memtailor/package.py
repos/spack_repo/builtin/packages/mesa/package.py
repos/spack_repo/builtin/packages/mfem/package.py
repos/spack_repo/builtin/packages/mgard/package.py
repos/spack_repo/builtin/packages/mount_point_attributes/package.py
repos/spack_repo/builtin/packages/mozjpeg/package.py
repos/spack_repo/builtin/packages/mpibind/package.py
repos/spack_repo/builtin/packages/opencascade/package.py
repos/spack_repo/builtin/packages/opencv/package.py
repos/spack_repo/builtin/packages/openfast/package.py
repos/spack_repo/builtin/packages/openfpgaloader/package.py
repos/spack_repo/builtin/packages/openmpi/package.py
repos/spack_repo/builtin/packages/openvdb/package.py
repos/spack_repo/builtin/packages/paraview/package.py
repos/spack_repo/builtin/packages/pdi/package.py
repos/spack_repo/builtin/packages/petsc/package.py
repos/spack_repo/builtin/packages/pfunit/package.py
repos/spack_repo/builtin/packages/pmix/package.py
repos/spack_repo/builtin/packages/procps/package.py
repos/spack_repo/builtin/packages/proj/package.py
repos/spack_repo/builtin/packages/prrte/package.py
repos/spack_repo/builtin/packages/psblas/package.py
repos/spack_repo/builtin/packages/pugixml/package.py
repos/spack_repo/builtin/packages/py_arkouda/package.py
repos/spack_repo/builtin/packages/py_beartype/package.py
repos/spack_repo/builtin/packages/py_biopython/package.py
repos/spack_repo/builtin/packages/py_chardet/package.py
repos/spack_repo/builtin/packages/py_cython/package.py
repos/spack_repo/builtin/packages/py_dill/package.py
repos/spack_repo/builtin/packages/py_exponax/package.py
repos/spack_repo/builtin/packages/py_fenics_basix/package.py
repos/spack_repo/builtin/packages/py_fenics_dolfinx/package.py
repos/spack_repo/builtin/packages/py_fenics_ffcx/package.py
repos/spack_repo/builtin/packages/py_flufl_lock/package.py
repos/spack_repo/builtin/packages/py_gevent/package.py
repos/spack_repo/builtin/packages/py_gpaw_data/package.py
repos/spack_repo/builtin/packages/py_illumina_utils/package.py
repos/spack_repo/builtin/packages/py_jax/package.py
repos/spack_repo/builtin/packages/py_jaxlib/package.py
repos/spack_repo/builtin/packages/py_keras/package.py
repos/spack_repo/builtin/packages/py_lightning_utilities/package.py
repos/spack_repo/builtin/packages/py_llvmlite/package.py
repos/spack_repo/builtin/packages/py_lxml/package.py
repos/spack_repo/builtin/packages/py_matplotlib/package.py
repos/spack_repo/builtin/packages/py_metaphlan/package.py
repos/spack_repo/builtin/packages/py_metatomic_torch/package.py
repos/spack_repo/builtin/packages/py_metatrain/package.py
repos/spack_repo/builtin/packages/py_numpy/package.py
repos/spack_repo/builtin/packages/py_petsc4py/package.py
repos/spack_repo/builtin/packages/py_pillow/package.py
repos/spack_repo/builtin/packages/py_pillow_simd/package.py
repos/spack_repo/builtin/packages/py_polars/package.py
repos/spack_repo/builtin/packages/py_protobuf/package.py
repos/spack_repo/builtin/packages/py_psycopg2/package.py
repos/spack_repo/builtin/packages/py_pygobject/package.py
repos/spack_repo/builtin/packages/py_ray/package.py
repos/spack_repo/builtin/packages/py_rioxarray/package.py
repos/spack_repo/builtin/packages/py_scikit_build_core/package.py
repos/spack_repo/builtin/packages/py_setuptools/package.py
repos/spack_repo/builtin/packages/py_setuptools_scm/package.py
repos/spack_repo/builtin/packages/py_slepc4py/package.py
repos/spack_repo/builtin/packages/py_textx/package.py
repos/spack_repo/builtin/packages/py_thinc/package.py
repos/spack_repo/builtin/packages/py_torchgeo/package.py
repos/spack_repo/builtin/packages/py_torchmetrics/package.py
repos/spack_repo/builtin/packages/py_ty/package.py
repos/spack_repo/builtin/packages/py_typer/package.py
repos/spack_repo/builtin/packages/py_tzlocal/package.py
repos/spack_repo/builtin/packages/py_uxarray/package.py
repos/spack_repo/builtin/packages/py_vesin/package.py
repos/spack_repo/builtin/packages/py_webdataset/package.py
repos/spack_repo/builtin/packages/py_xarray/package.py
repos/spack_repo/builtin/packages/py_xdot/package.py
repos/spack_repo/builtin/packages/python/package.py
repos/spack_repo/builtin/packages/qgis/package.py
repos/spack_repo/builtin/packages/qt/package.py
repos/spack_repo/builtin/packages/qt_5compat/package.py
repos/spack_repo/builtin/packages/qt_base/package.py
repos/spack_repo/builtin/packages/qt_declarative/package.py
repos/spack_repo/builtin/packages/qt_quick3d/package.py
repos/spack_repo/builtin/packages/qt_quicktimeline/package.py
repos/spack_repo/builtin/packages/qt_shadertools/package.py
repos/spack_repo/builtin/packages/qt_svg/package.py
repos/spack_repo/builtin/packages/qt_tools/package.py
repos/spack_repo/builtin/packages/quandary/package.py
repos/spack_repo/builtin/packages/rdkit/package.py
repos/spack_repo/builtin/packages/re2c/package.py
repos/spack_repo/builtin/packages/relion/package.py
repos/spack_repo/builtin/packages/repeatmodeler/package.py
repos/spack_repo/builtin/packages/rocwmma/package.py
repos/spack_repo/builtin/packages/roms/package.py
repos/spack_repo/builtin/packages/root/package.py
repos/spack_repo/builtin/packages/salome_configuration/package.py
repos/spack_repo/builtin/packages/salome_med/package.py
repos/spack_repo/builtin/packages/salome_medcoupling/package.py
repos/spack_repo/builtin/packages/slepc/package.py
repos/spack_repo/builtin/packages/sst_core/package.py
repos/spack_repo/builtin/packages/stat/package.py
repos/spack_repo/builtin/packages/surfer/package.py
repos/spack_repo/builtin/packages/swig/package.py
repos/spack_repo/builtin/packages/vasp/package.py
repos/spack_repo/builtin/packages/vecgeom/package.py
repos/spack_repo/builtin/packages/vecmem/package.py
repos/spack_repo/builtin/packages/verilator/package.py
repos/spack_repo/builtin/packages/viskores/package.py
repos/spack_repo/builtin/packages/vtk/package.py
repos/spack_repo/builtin/packages/xerces_c/package.py
repos/spack_repo/builtin/packages/xyce/package.py
repos/spack_repo/builtin/packages/xz/package.py
repos/spack_repo/builtin/packages/yosys/package.py
repos/spack_repo/builtin/packages/zlib_ng/package.py
�[1;34m==> �[0mrunning flake8
repos/spack_repo/builtin/packages/qgis/package.py:30: [E128] continuation line under-indented for visual indent
repos/spack_repo/builtin/packages/qgis/package.py:31: [E128] continuation line under-indented for visual indent
repos/spack_repo/builtin/packages/qgis/package.py:32: [E124] closing bracket does not match visual indentation
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

@adamjstewart adamjstewart merged commit 0f622f8 into spack:develop Mar 11, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants