Skip to content

hdf5: add cxxstd variant#3768

Open
balos1 wants to merge 3 commits intospack:developfrom
balos1:add-cxxstd-to-hdf5
Open

hdf5: add cxxstd variant#3768
balos1 wants to merge 3 commits intospack:developfrom
balos1:add-cxxstd-to-hdf5

Conversation

@balos1
Copy link
Member

@balos1 balos1 commented Mar 9, 2026

No description provided.

@hyoklee
Copy link
Contributor

hyoklee commented Mar 10, 2026

Hi, @balos1 ! Thank you for your contribution. Would you please fix Python code style and make CI pass?

@balos1
Copy link
Member Author

balos1 commented Mar 10, 2026

@spackbot style

@balos1
Copy link
Member Author

balos1 commented Mar 10, 2026

CC @white238

@balos1
Copy link
Member Author

balos1 commented Mar 10, 2026

@spackbot fix style

@spackbot-app
Copy link

spackbot-app bot commented Mar 10, 2026

Let me see if I can fix that for you!

@balos1 balos1 requested a review from white238 March 10, 2026 20:22
@spackbot-app
Copy link

spackbot-app bot commented Mar 10, 2026

I was able to run spack style --fix for you!

spack style --fix
repos/spack_repo/builtin/packages/acts_algebra_plugins/package.py
repos/spack_repo/builtin/packages/detray/package.py
repos/spack_repo/builtin/packages/duckdb/package.py
repos/spack_repo/builtin/packages/exiv2/package.py
repos/spack_repo/builtin/packages/gnupg/package.py
repos/spack_repo/builtin/packages/green_mbpt/package.py
repos/spack_repo/builtin/packages/hdf5/package.py
repos/spack_repo/builtin/packages/llvm/package.py
repos/spack_repo/builtin/packages/memcached/package.py
repos/spack_repo/builtin/packages/mfem/package.py
repos/spack_repo/builtin/packages/py_cython/package.py
repos/spack_repo/builtin/packages/py_scikit_build_core/package.py
repos/spack_repo/builtin/packages/py_slepc4py/package.py
repos/spack_repo/builtin/packages/slepc/package.py
�[1;34m==> �[0mrunning flake8
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
�[1;34m==> �[0mstyle checks passed
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

@balos1 balos1 changed the title add cxxstd variant to hdf5 hdf5: add cxxstd variant Mar 10, 2026
variant("cxx", default=False, description="Enable C++ support")
variant(
"cxxstd",
default="98",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default C++ standard is C++11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants