Skip to content

axom: Add 0.13.0, add new RAJA versions #3866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmhan12 wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

axom: Add 0.13.0, add new RAJA versions #3866

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca13e9d
Axom v0.13.0 recipe changes
bmhan12 Mar 16, 2026
2b8e7ce
Changes to satisfy spack audit; cascading changes to ensure variant f…
bmhan12 Mar 16, 2026
d60106a
Future proof for patch release versioning
bmhan12 Mar 17, 2026
efb8324
Consistency for potential versions
bmhan12 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
156 changes: 134 additions & 22 deletions repos/spack_repo/builtin/packages/axom/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,24 @@

from spack.package import *

# Axom components we expose to Spack. Core is always built and is not listed here.
_AXOM_COMPONENTS = (
"bump",
"inlet",
"klee",
"lumberjack",
"mint",
"mir",
"multimat",
"primal",
"quest",
"sidre",
"sina",
"slam",
"slic",
"spin",
)


def get_spec_path(spec, package_name, path_replacements={}, use_bin=False):
"""Extracts the prefix path for the given spack package
Expand Down Expand Up @@ -53,6 +71,7 @@ class Axom(CachedCMakePackage, CudaPackage, ROCmPackage):

version("main", branch="main")
version("develop", branch="develop")
version("0.13.0", tag="v0.13.0", commit="d00f6c66ef390ad746ae840f1074d982513611ac")
version("0.12.0", tag="v0.12.0", commit="297544010a3dfb98145a1a85f09f9c648c00a18c")
version("0.11.0", tag="v0.11.0", commit="685960486aa55d3a74a821ee02f6d9d9a3e67ab1")
version("0.10.1", tag="v0.10.1", commit="6626ee1c5668176fb64dd9a52dec3e8596b3ba6b")
Expand Down Expand Up @@ -101,10 +120,31 @@ class Axom(CachedCMakePackage, CudaPackage, ROCmPackage):
variant(
"profiling",
default=False,
when="@develop",
description="Build with hooks for Adiak/Caliper performance analysis",
when="@:0.12",
description="Build with hooks for Adiak/Caliper performance analysis. "
"Deprecated -- use the adiak and/or caliper variants directly "
"versions 0.13.0 and onwards.",
)

# variant for Axom components
variant(
"components",
description=(
"Comma separated list of Axom components to enable. "
"'all' enables all components; 'none' disables all components "
"Missing dependencies will be added (e.g. we'll add `sidre` "
"and `conduit` for `components=inlet`)"
),
values=any_combination_of("all", *_AXOM_COMPONENTS).with_default("all"),
)

variant("int64", default=True, description="Use 64bit integers for IndexType")
Copy link
Contributor Author

@bmhan12 bmhan12 Mar 17, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left the default to True, same as the Axom repo recipe.

For reference: +int64/AXOM_USE_64BIT_INDEXTYPE has been defaulted to True since version 0.12.0 going off of the release notes: https://github.com/llnl/axom/blob/develop/RELEASE-NOTES.md


# variants for package dependencies
variant("adiak", default=False, when="@0.13:", description="Build with adiak")
variant("caliper", default=False, when="@0.13:", description="Build with caliper")
variant("conduit", default=True, description="Build with conduit")

variant("opencascade", default=False, description="Build with opencascade")

variant("mfem", default=False, description="Build with mfem")
Expand Down Expand Up @@ -140,9 +180,10 @@ class Axom(CachedCMakePackage, CudaPackage, ROCmPackage):

# Libraries
# Forward variants to Conduit
for _var in ["fortran", "hdf5", "mpi", "python"]:
depends_on("conduit+{0}".format(_var), when="+{0}".format(_var))
depends_on("conduit~{0}".format(_var), when="~{0}".format(_var))
with when("+conduit"):
for _var in ["fortran", "hdf5", "mpi", "python"]:
depends_on("conduit+{0}".format(_var), when="+{0}".format(_var))
depends_on("conduit~{0}".format(_var), when="~{0}".format(_var))

depends_on("conduit+python", when="+devtools")
depends_on("conduit~python", when="~devtools")
Expand All @@ -156,6 +197,7 @@ class Axom(CachedCMakePackage, CudaPackage, ROCmPackage):

with when("+umpire"):
depends_on("umpire")
depends_on("umpire@2025.12:", when="@0.13:")
depends_on("umpire@2025.09:", when="@0.12:")
depends_on("umpire@2025.03", when="@0.11")
depends_on("umpire@2024.07", when="@0.10")
Expand All @@ -168,6 +210,7 @@ class Axom(CachedCMakePackage, CudaPackage, ROCmPackage):

with when("+raja"):
depends_on("raja")
depends_on("raja@2025.12.1:", when="@0.13:")
depends_on("raja@2025.09:", when="@0.12:")
depends_on("raja@2025.03", when="@0.11")
depends_on("raja@2024.07", when="@0.10")
Expand All @@ -178,6 +221,10 @@ class Axom(CachedCMakePackage, CudaPackage, ROCmPackage):
depends_on("raja~openmp", when="~openmp")
depends_on("raja+openmp", when="+openmp")

# we're planning to remove support for the profiling variant,
# but still need to support it for now
depends_on("adiak", when="+adiak")
depends_on("caliper", when="+caliper")
with when("+profiling"):
depends_on("adiak")
depends_on("caliper+adiak~papi")
Expand All @@ -194,17 +241,27 @@ class Axom(CachedCMakePackage, CudaPackage, ROCmPackage):
depends_on(f"{dep}+shared", when="+shared")
depends_on(f"{dep}~shared", when="~shared")

with when("+adiak"):
for fwd in ("mpi", "shared"):
depends_on(f"adiak+{fwd}", when=f"+{fwd}")

with when("+caliper"):
for fwd in ("cuda", "rocm", "mpi", "shared"):
depends_on(f"caliper+{fwd}", when=f"+{fwd}")
Comment on lines +244 to +250
Copy link
Contributor Author

@bmhan12 bmhan12 Mar 17, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the axom repo recipe these were originally ^adiak/^caliper, but spack audit / CI was not happy with the dependency-check-based logic.

I've converted them to +adiak/+caliper for the 0.13.0 and onwards case, while +profiling keeps its pre-existing caliper/adiak logic for the 0.12.0 and older case.

Copy link
Contributor

@kennyweiss kennyweiss Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I had ^adiak/^caliper to support the case where these dependencies were activated by +profiling, but the user did not activate the adiak or caliper variants.

If this is better, I'm happy with it..


for val in CudaPackage.cuda_arch_values:
ext_cuda_dep = f"+cuda cuda_arch={val}"
depends_on(f"raja {ext_cuda_dep}", when=f"+raja {ext_cuda_dep}")
depends_on(f"umpire {ext_cuda_dep}", when=f"+umpire {ext_cuda_dep}")
depends_on(f"caliper {ext_cuda_dep}", when=f"+caliper {ext_cuda_dep}")
depends_on(f"caliper {ext_cuda_dep}", when=f"+profiling {ext_cuda_dep}")
depends_on(f"mfem {ext_cuda_dep}", when=f"+mfem {ext_cuda_dep}")

for val in ROCmPackage.amdgpu_targets:
ext_rocm_dep = f"+rocm amdgpu_target={val}"
depends_on(f"raja {ext_rocm_dep}", when=f"+raja {ext_rocm_dep}")
depends_on(f"umpire {ext_rocm_dep}", when=f"+umpire {ext_rocm_dep}")
depends_on(f"caliper {ext_rocm_dep}", when=f"+caliper {ext_rocm_dep}")
depends_on(f"caliper {ext_rocm_dep}", when=f"+profiling {ext_rocm_dep}")
depends_on(f"mfem {ext_rocm_dep}", when=f"+mfem {ext_rocm_dep}")

Expand Down Expand Up @@ -234,6 +291,30 @@ class Axom(CachedCMakePackage, CudaPackage, ROCmPackage):
# (ENABLE_CLANGFORMAT will be OFF if not the exact version)
depends_on("llvm+clang@19", type="build")

# Component requirements
# -----------------------------------------------------------------------
# Hard inter-component dependencies taken from Axom's dependency graph.
requires(f"components={','.join(_AXOM_COMPONENTS)}", when="components=all")

requires("components=slic,spin,primal", when="components=bump")
requires("components=sidre,slic,primal", when="components=inlet")
requires("components=sidre,slic,inlet,primal", when="components=klee")
requires("components=slic,slam", when="components=mint")
requires("components=bump,slic,slam,primal", when="components=mir")
requires("components=slic,slam", when="components=multimat")
requires("components=slic", when="components=primal")
requires("components=slic,slam,primal,mint,spin", when="components=quest")
requires("components=slic", when="components=sidre")
requires("components=slic", when="components=sina")
requires("components=slic", when="components=slam")
requires("components=slic,slam,primal", when="components=spin")

# Hard dependencies of Axom components on other packages
requires("+conduit", when="components=bump")
requires("+conduit", when="components=mir")
requires("+conduit", when="components=sidre")
requires("+conduit", when="components=sina")

# -----------------------------------------------------------------------
# Conflicts
# -----------------------------------------------------------------------
Expand Down Expand Up @@ -520,35 +601,64 @@ def initconfig_package_entries(self):
entries = []
path_replacements = {}

all_components_enabled = all(
spec.satisfies(f"components={comp}") for comp in _AXOM_COMPONENTS
)

if all_components_enabled:
print("All axom components enabled")
else:
print(
f"The following Axom components are enabled: {spec.variants['components'].value}"
)

entries.append("#------------------{0}".format("-" * 60))
entries.append("# Axom components")
entries.append("#------------------{0}\n".format("-" * 60))
entries.append(cmake_cache_option("AXOM_ENABLE_ALL_COMPONENTS", False))

for comp in spec.variants["components"].value:
if comp in _AXOM_COMPONENTS:
entries.append(cmake_cache_option(f"AXOM_ENABLE_{comp.upper()}", True))

# TPL locations
entries.append("#------------------{0}".format("-" * 60))
entries.append("# TPLs")
entries.append("#------------------{0}\n".format("-" * 60))

# Try to find the common prefix of the TPL directory.
# If found, we will use this in the TPL paths
path1 = os.path.realpath(spec["conduit"].prefix)
path2 = os.path.realpath(self.prefix)
self.find_path_replacement(path1, path2, path_replacements, "TPL_ROOT", entries)

conduit_dir = get_spec_path(spec, "conduit", path_replacements)
entries.append(cmake_cache_path("CONDUIT_DIR", conduit_dir))

# optional tpls
for dep in ("mfem", "hdf5", "lua", "raja", "umpire", "opencascade"):
if spec.satisfies("+%s" % dep):
variant_deps = [
"conduit",
"c2c",
"mfem",
"hdf5",
"lua",
"raja",
"umpire",
"opencascade",
"adiak",
"caliper",
]

for dep in variant_deps:
if dep in ["lua"]: # skip entries often outside the common prefix
continue

if spec.satisfies(f"^{dep}"):
path1 = os.path.realpath(spec[dep].prefix)
path2 = os.path.realpath(os.path.dirname(self.prefix))
self.find_path_replacement(path1, path2, path_replacements, "TPL_ROOT", entries)
break

# optional tpls based on variants
for dep in variant_deps:
if spec.satisfies(f"^{dep}"):
dep_dir = get_spec_path(spec, dep, path_replacements)
entries.append(cmake_cache_path("%s_DIR" % dep.upper(), dep_dir))
else:
entries.append("# %s not built\n" % dep.upper())

if spec.satisfies("+profiling"):
dep_dir = get_spec_path(spec, "adiak", path_replacements)
entries.append(cmake_cache_path("ADIAK_DIR", dep_dir))

dep_dir = get_spec_path(spec, "caliper", path_replacements)
entries.append(cmake_cache_path("CALIPER_DIR", dep_dir))

if spec.satisfies("+umpire") and spec.satisfies("^camp"):
dep_dir = get_spec_path(spec, "camp", path_replacements)
entries.append(cmake_cache_path("CAMP_DIR", dep_dir))
Expand Down Expand Up @@ -645,6 +755,8 @@ def cmake_args(self):
options.append(self.define_from_variant("AXOM_ENABLE_EXAMPLES", "examples"))
options.append(self.define_from_variant("AXOM_ENABLE_TOOLS", "tools"))
options.append(self.define_from_variant("AXOM_ENABLE_TUTORIALS", "tutorials"))
options.append(self.define_from_variant("AXOM_USE_64BIT_INDEXTYPE", "int64"))

if self.spec.satisfies("~raja") or self.spec.satisfies("+umpire"):
options.append("-DAXOM_ENABLE_MIR:BOOL=OFF")

Expand Down
Loading