perf(ansible): add ControlPersist for SSH connection reuse #4317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gardar <[email protected]>
|
Not sure if there's anything special in my environment (not that I know of), but doing this doesn't seem to have any impact.
|
|
Perhaps you already have controlpersist in your ssh config? |
|
the impact depends on how fast you establish a connection from your device (like laptop) to a server. With a fast internet connection and low ping to the server, you may not see any difference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should speed up playbook execution significantly for most users.
While pipelining is already enabled and reduces per-task work inside each SSH session, ControlPersist reduces the cost of establishing SSH sessions by reusing the master connection.