Hotfix Syllabus by happycastle114 · Pull Request #111 · sparcs-kaist/legacy-v3-otlplus-web

happycastle114 · 2025-08-03T10:58:27Z

Summary by CodeRabbit

New Features
- Updated the way syllabus links are generated, now using a secure, encoded format for improved compatibility with external systems.
Bug Fixes
- Improved handling of lecture information in syllabus URLs to ensure accurate and consistent access.

Fix lectureUtil.ts

coderabbitai · 2025-08-03T10:58:33Z

Caution

Review failed

The pull request is closed.

Walkthrough

The implementation of the getSyllabusUrl function in src/utils/lectureUtils.ts was updated. Instead of generating a URL with multiple query parameters, the function now creates a JSON payload using selected lecture properties, base64-encodes it, and appends it as a single params parameter to a new base URL. The function signature remains unchanged.

Changes

Cohort / File(s)	Change Summary
Syllabus URL Construction `src/utils/lectureUtils.ts`	Refactored `getSyllabusUrl` to generate a base64-encoded JSON payload as a single query parameter for a new endpoint.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant lectureUtils.ts

    Caller->>lectureUtils.ts: getSyllabusUrl(lecture)
    lectureUtils.ts->>lectureUtils.ts: Construct JSON payload from lecture fields
    lectureUtils.ts->>lectureUtils.ts: Base64-encode JSON payload
    lectureUtils.ts->>Caller: Return URL with encoded params

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A bunny hops with code anew,
Syllabus links now hidden from view.
With base64 and JSON tight,
URLs encoded just right.
One query param, neat and small—
The lecture’s secrets wrapped for all!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 81115c1 and 9e9ffde.

📒 Files selected for processing (1)

src/utils/lectureUtils.ts (1 hunks)

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch rc

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Copilot

Pull Request Overview

This hotfix updates the syllabus URL generation logic to use a new KAIST ERP system endpoint instead of the old CAIS system. The change modifies how syllabus links are constructed by switching from URL parameters to a base64-encoded JSON payload format.

Replaced the old CAIS syllabus URL format with a new ERP system endpoint
Changed from URL query parameters to a base64-encoded JSON payload structure
Updated field mappings to match the new API requirements

Copilot · 2025-08-03T10:58:51Z

src/utils/lectureUtils.ts

+  const payload = {
+    syy: String(lecture.year),
+    smtDivCd: String(lecture.semester),
+    subjtCd: lecture.old_code,


The code references 'lecture.old_code' but the original implementation used 'lecture.code'. Verify that 'old_code' property exists on the Lecture type and contains the correct subject code for the new ERP system.

Suggested change

subjtCd: lecture.old_code,

subjtCd: lecture.old_code ?? lecture.code,

Copilot · 2025-08-03T10:58:52Z

src/utils/lectureUtils.ts

+    subjtCd: lecture.old_code,
+    syllabusOpenYn: '0',
+  };
+  const encodedLecture = btoa(JSON.stringify(payload));


Using btoa() for encoding could fail if the JSON string contains non-ASCII characters. Consider using encodeURIComponent() or a more robust base64 encoding method to handle international characters in lecture data.

Suggested change

const encodedLecture = btoa(JSON.stringify(payload));

const encodedLecture = btoa(unescape(encodeURIComponent(JSON.stringify(payload))));

happycastle114 added 2 commits August 3, 2025 19:46

Fix lectureUtil.ts

10782e3

Merge pull request #110 from sparcs-kaist/fix-syllabus-url

9e9ffde

Fix lectureUtil.ts

Copilot AI review requested due to automatic review settings August 3, 2025 10:58

Copilot AI reviewed Aug 3, 2025

View reviewed changes

happycastle114 merged commit 2891812 into release Aug 3, 2025
5 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hotfix Syllabus#111

Hotfix Syllabus#111
happycastle114 merged 2 commits intoreleasefrom
rc

happycastle114 commented Aug 3, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Aug 3, 2025 •

edited

Loading

Review failed

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 3, 2025

Uh oh!

Copilot AI Aug 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	subjtCd: lecture.old_code,
	subjtCd: lecture.old_code ?? lecture.code,

	const encodedLecture = btoa(JSON.stringify(payload));
	const encodedLecture = btoa(unescape(encodeURIComponent(JSON.stringify(payload))));

Conversation

happycastle114 commented Aug 3, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Aug 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

happycastle114 commented Aug 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)