Skip to content

fix: Minor comments #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucas-manuel merged 2 commits into from
Dec 19, 2025
Merged

fix: Minor comments #206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02a19b2
fix: Minor issues, Typos & Documentation C11
supercontracts Dec 18, 2025
ed6ff2f
Merge branch 'dev' into fix/cantina-11-comments
lucas-manuel Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/libraries/UniswapV4Lib.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ library UniswapV4Lib {
_requirePoolIdMatch(poolId, poolKey);

// Since funds are being added to the position, the ticks of the position need to be checked
// since it's possible the position was transferred to the proxy, and its tick range may not
// adhere to the constraints that would have been applied if it were minted by the proxy.
// against the current constraints, since it's possible the position was minted under
// outdated tick limits, or was transferred to the proxy.
_checkTickLimits(tickLimits[poolId], info.tickLower(), info.tickUpper());

bytes memory callData = _getIncreaseLiquidityCallData({
Expand Down Expand Up @@ -183,6 +183,7 @@ library UniswapV4Lib {
);

// Perform rate limit decrease.
// NOTE: Rate limit decrease does not account for the net amount of tokenIn actually taken.
IRateLimits(rateLimits).triggerRateLimitDecrease(
RateLimitHelpers.makeBytes32Key(LIMIT_SWAP, poolId),
_getNormalizedBalance(tokenIn, amountIn)
Expand Down Expand Up @@ -280,7 +281,7 @@ library UniswapV4Lib {
);
}

// Finally, approve the Position Manager contract to spend the token via Permit2.
// Finally, approve the spender to spend the token via Permit2.
IALMProxy(proxy).doCall(
_PERMIT2,
abi.encodeCall(
Expand Down Expand Up @@ -319,7 +320,7 @@ library UniswapV4Lib {
// Account for the theoretical possibility of receiving tokens when adding liquidity by
// using a clamped subtraction.
// NOTE: The limitation of this integration is the assumption that the tokens are valued
// equally (i.e. 1.00000 USDC = 1.000000000000000000 USDS).
// equally (i.e. 1.000000 USDC = 1.000000000000000000 USDS).
uint256 rateLimitDecrease = _clampedSub(
_getNormalizedBalance(token0, startingBalance0) +
_getNormalizedBalance(token1, startingBalance1),
Expand All @@ -328,15 +329,13 @@ library UniswapV4Lib {
);

// Perform rate limit decrease.
// NOTE: Rate limit decrease is net of any token0 or token1 received due to fees.
IRateLimits(rateLimits).triggerRateLimitDecrease(
RateLimitHelpers.makeBytes32Key(LIMIT_DEPOSIT, poolId),
rateLimitDecrease
);

// Reset approval of Permit2 in token0 and token1
// NOTE: It's not necessary to reset the Position Manager approval in Permit2 (as it
// doesn't have allowance in the token at this point), but prudent so there isn't a
// hanging unused approval.
// Reset approvals for token0 and token1.
_approveWithPermit2(proxy, token0, _POSITION_MANAGER, 0);
_approveWithPermit2(proxy, token1, _POSITION_MANAGER, 0);
}
Expand All @@ -363,12 +362,13 @@ library UniswapV4Lib {
uint256 endingBalance1 = _getBalance(token1, proxy);

// NOTE: The limitation of this integration is the assumption that the tokens are valued
// equally (i.e. 1.00000 USDC = 1.000000000000000000 USDS).
// equally (i.e. 1.000000 USDC = 1.000000000000000000 USDS).
uint256 rateLimitDecrease =
_getNormalizedBalance(token0, endingBalance0 - startingBalance0) +
_getNormalizedBalance(token1, endingBalance1 - startingBalance1);

// Perform rate limit decrease.
// NOTE: Rate limit decrease includes any token0 or token1 received due to fees.
IRateLimits(rateLimits).triggerRateLimitDecrease(
RateLimitHelpers.makeBytes32Key(LIMIT_WITHDRAW, poolId),
rateLimitDecrease
Expand Down
Loading