fix: min and max tick bounds C21

[deluca-mike]

Summary by CodeRabbit

• Bug Fixes

  • Enhanced parameter validation with stricter bounds checking for tick limit configuration, including validation for minimum and maximum acceptable values.

• Tests

  • Added test cases for boundary condition validation to ensure proper error handling.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[octane-security-app]

Summary by Octane

New Contracts

No new contracts were added.

Updated Contracts

• MainnetController.sol: The smart contract now integrates Uniswap's TickMath for tick validation, enhancing pool configuration constraints.

---

🔗 Commit Hash: 922a1a2

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This change imports TickMath from Uniswap V4 core and tightens validation in the setUniswapV4TickLimits admin function to enforce tick parameter bounds (MIN_TICK and MAX_TICK). Corresponding test cases verify the new validation constraints.

Changes

Cohort / File(s)	Change Summary
Validation & Import src/MainnetController.sol	Added TickMath import from Uniswap V4; tightened setUniswapV4TickLimits validation to require valid tick ranges (tickLowerMin ≥ MIN_TICK, tickUpperMax ≤ MAX_TICK) when parameters are non-zero.
Test Coverage test/unit/controllers/Admin.t.sol	Added two revert scenarios to test_setUniswapV4TickLimits_revertsWhenInvalidTicks for tickLowerMin < MIN_TICK and tickUpperMax > MAX_TICK cases.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Straightforward addition of TickMath import and localized bounds validation in a single admin function
• Two parallel test cases with identical structure and minimal assertion logic

Possibly related PRs

• feat: UniswapV4 mint/increase/decrease liquidity support #189 – Introduces initial Uniswap V4 support including the setUniswapV4TickLimits function that this PR now validates more strictly.
• feat: Apply Tick Checks on increaseLiquidityUniswapV4 (SC-1262) #197 – Applies Uniswap V4 tick limit checks into mint/increase flows and UniswapV4Lib, building on the validation tightened here.

Suggested labels

Status: Ready for Review

Suggested reviewers

• lucas-manuel
• supercontracts

Poem

🐰 A rabbit hops through tick bounds tight,
No more stray values left and right!
With TickMath's guard rails firm in place,
Uniswap V4 runs at proper pace.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/cantina-21-min-max-ticks

---

📜 Recent review details

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f8e16e4 and 922a1a2.

📒 Files selected for processing (2)

• src/MainnetController.sol (2 hunks)
• test/unit/controllers/Admin.t.sol (1 hunks)

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Coverage after merging fix/cantina-21-min-max-ticks into dev will be

99.36%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
deploy
ControllerDeploy.sol	100%	100%	100%	100%
ForeignControllerInit.sol	100%	100%	100%	100%
MainnetControllerInit.sol	97.37%	93.33%	100%	100%	152, 90
src
ALMProxy.sol	100%	100%	100%	100%
ALMProxyFreezable.sol	100%	100%	100%	100%
ForeignController.sol	94.90%	84.62%	95.65%	97.22%	128–129, 129, 129, 316–317, 573
MainnetController.sol	99.18%	100%	98.28%	99.24%	552–553
OTCBuffer.sol	100%	100%	100%	100%
RateLimitHelpers.sol	100%	100%	100%	100%
RateLimits.sol	100%	100%	100%	100%
src/libraries
AaveLib.sol	100%	100%	100%	100%
ApproveLib.sol	100%	100%	100%	100%
CCTPLib.sol	100%	100%	100%	100%
CurveLib.sol	100%	100%	100%	100%
ERC4626Lib.sol	96%	75%	100%	100%	108
PSMLib.sol	100%	100%	100%	100%
UniswapV4Lib.sol	99.31%	95.65%	100%	100%	278

[octane-security-app]

Overview

Vulnerabilities found:	8

Warnings found:	12

---

🔗 Commit Hash: 922a1a2
🛡️ Octane Dashboard: All vulnerabilities