feat: Add additional requirements/assumptions (C-22)

[lucas-manuel]

Summary by CodeRabbit

• Documentation
  • Clarified Ethena's delegated signer role configuration and related order validity checks
  • Added requirement that Uniswap V4 pool onboardings use 1:1 assets

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Documentation updates to README.md clarifying that Ethena's delegated signer role can be set by the RELAYER and Order Validity Checks are trusted to prevent attacks, plus a requirement that all Uniswap V4 pool onboardings use 1:1 assets.

Changes

Cohort / File(s)	Summary
Documentation README.md	Added clarifications on Ethena delegated signer role permissions, Order Validity Checks as a security control, and Uniswap V4 pool onboarding asset pair requirements

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Documentation-only changes with no code logic modifications
• Single file affected (README.md)
• No functional behavior changes or exported declarations affected

Poem

🐰 A rabbit hops through docs so fine,
With Ethena's role now clear as brine,
V4 pools need one-to-one to shine,
Order checks keep attacks in line! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'feat: Add additional requirements/assumptions (C-22)' follows the required format (starts with 'feat: ' prefix) and accurately describes the main changes in the PR, which adds documentation about Ethena's delegated signer role and Uniswap V4 pool onboarding requirements.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d54b80d and a8dd973.

📒 Files selected for processing (1)

• README.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: test
• GitHub Check: coverage
• GitHub Check: build

🔇 Additional comments (2)

README.md (2)

151-151: Clear and well-placed operational requirement.

The requirement that all Uniswap V4 pool onboardings use 1:1 assets is clearly stated and appropriately placed in the Operational Requirements section, complementing existing constraints on ERC-4626 vaults and token specifications.

---

143-143: The Ethena documentation link referenced is current and accessible. The Order Validity Checks page documents validations conducted to ensure both user and protocol can honour signed orders before blockchain submission, confirming the link remains valid and relevant to the trust assumption mentioned in the README.

[github-actions]

Coverage after merging add-ethena-trust-assumptions into dev will be

99.36%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
deploy
ControllerDeploy.sol	100%	100%	100%	100%
ForeignControllerInit.sol	100%	100%	100%	100%
MainnetControllerInit.sol	97.37%	93.33%	100%	100%	152, 90
src
ALMProxy.sol	100%	100%	100%	100%
ALMProxyFreezable.sol	100%	100%	100%	100%
ForeignController.sol	94.90%	84.62%	95.65%	97.22%	128–129, 129, 129, 316–317, 573
MainnetController.sol	99.18%	100%	98.28%	99.24%	538–539
OTCBuffer.sol	100%	100%	100%	100%
RateLimitHelpers.sol	100%	100%	100%	100%
RateLimits.sol	100%	100%	100%	100%
src/libraries
AaveLib.sol	100%	100%	100%	100%
ApproveLib.sol	100%	100%	100%	100%
CCTPLib.sol	100%	100%	100%	100%
CurveLib.sol	100%	100%	100%	100%
ERC4626Lib.sol	96%	75%	100%	100%	108
PSMLib.sol	100%	100%	100%	100%
UniswapV4Lib.sol	99.33%	96%	100%	100%	284