-
Notifications
You must be signed in to change notification settings - Fork 30
feat: Add v1.9.0 release #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
ecba4d3
58a0735
2aed93a
651885e
01094c8
a97565b
3e9be4e
29edee5
c948112
235186f
9ef81e8
9441a7e
c1e80c4
61cbc57
7b59cf5
3fe3072
f8e16e4
3d2d0dd
d54b80d
3dbc7cb
16525ad
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -6,5 +6,7 @@ | |||||||||||||
| "freezer": "0x90D8c80C028B4C09C0d8dcAab9bbB057F0513431", | ||||||||||||||
| "usdc": "0xaf88d065e77c8cC2239327C5EDb3A432268e5831", | ||||||||||||||
| "usds": "0x6491c05A82219b8D1479057361ff1654749b876b", | ||||||||||||||
| "susds": "0xdDb46999F8891663a8F2828d25298f70416d7610" | ||||||||||||||
| "susds": "0xdDb46999F8891663a8F2828d25298f70416d7610", | ||||||||||||||
| "almProxy": "0x92afd6F2385a90e44da3a8B60fe36f6cBe1D8709", | ||||||||||||||
| "rateLimits": "0x19D08879851FB54C2dCc4bb32b5a1EA5E9Ad6838" | ||||||||||||||
|
Comment on lines
+9
to
+11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial Inconsistent field ordering. The field order is 🔎 Suggested reordering for consistency "susds": "0xdDb46999F8891663a8F2828d25298f70416d7610",
- "almProxy": "0x92afd6F2385a90e44da3a8B60fe36f6cBe1D8709",
- "rateLimits": "0x19D08879851FB54C2dCc4bb32b5a1EA5E9Ad6838"
+ "rateLimits": "0x19D08879851FB54C2dCc4bb32b5a1EA5E9Ad6838",
+ "almProxy": "0x92afd6F2385a90e44da3a8B60fe36f6cBe1D8709"📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||
| } | ||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 701
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 130
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 102
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 33697
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 11041
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 1006
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 4025
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 1129
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 3283
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 1894
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 167
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 3408
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 57
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 752
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 1212
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 1147
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 102
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 463
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 57
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 57
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 2166
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 1081
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 268
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 2408
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 2440
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 2441
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 277
🏁 Script executed:
Repository: sparkdotfi/spark-alm-controller
Length of output: 270
Add validation to enforce the 1:1 asset constraint for Uniswap V4 pools.
The 1:1 asset requirement is documented in the README but not enforced in code. The
setUniswapV4TickLimitsfunction only validates tick parameters without checking that token0 and token1 are equal-valued assets. While the_increaseLiquidityfunction includes a comment acknowledging the assumption that tokens are valued equally, no programmatic validation prevents configuring pools with mismatched asset values.This is critical because the rate limit calculation normalizes both tokens to 18 decimals and sums them without accounting for actual USD values (per the learned design decision about normalized balances). An admin could inadvertently—or maliciously—configure a non-1:1 pool and create a rate limit bypass via price discrepancies.
Consider adding validation in
setUniswapV4TickLimitsto verify token0 and token1 are equal-valued assets before allowing pool configuration.🤖 Prompt for AI Agents