fix: WEETHModule to use safeTransfer (DEV-1150)

[supercontracts]

Summary by CodeRabbit

• Refactor

  • Enhanced WETH transfer safety during withdrawals by implementing safer ERC20 transfer semantics, improving protection against non-compliant token implementations.

• Chores

  • Adjusted internal interface definitions and test configurations to support improved transfer mechanisms.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[notion-workspace]

Use safeTransfer in weETH module and remove getEETHByWeETH function in IWEETHLike interface

[octane-security-app]

Summary by Octane

New Contracts

No new contracts were added.

Updated Contracts

• WeEthModule.sol: The smart contract now uses SafeERC20 for secure token transfers, enhancing safety in token operations.
• WeETHLib.sol: Removed the getEETHByWeETH function from IWEETHLike interface.

---

🔗 Commit Hash: f6b20c4

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

Walkthrough

The changes enhance WETH transfer safety in WeEthModule by implementing SafeERC20 wrappers for ERC20 interactions. The IWEETHLike interface is refactored: the getEETHByWeETH function is removed from the library and re-declared locally in the test file.

Changes

Cohort / File(s)	Summary
SafeERC20 Integration src/WeEthModule.sol	Added SafeERC20 import and applied it to IERC20. Modified WETH transfer during withdrawal to use safeTransfer instead of direct transfer, improving compatibility with non-standard ERC20 implementations.
Interface Refactoring src/libraries/WeETHLib.sol, test/mainnet-fork/weETH.t.sol	Removed getEETHByWeETH function from IWEETHLike interface in WeETHLib. Added local IWEETHLike interface declaration in test file with eETH() and getEETHByWeETH(uint256) functions to replace the removed library export.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• [DEV-1041] : Add weETH integration #215: Introduced WeEthModule.sol, WeETHLib.sol, and weETH test files that are directly modified in this PR.

Suggested reviewers

• lucas-manuel

Poem

🐰 SafeERC20 wraps our transfers tight,
No more risky calls in the night!
Interfaces shuffle, tests adapt with grace,
Safety and clarity win the race! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: using safeTransfer in WEETHModule. It follows the required format with 'fix:' prefix and includes the JIRA key (DEV-1150). The changes confirm this is the primary modification across the codebase.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch dev-1150-fix-weethModule

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• DEV-1150: Entity not found: Issue - Could not find referenced Issue.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[octane-security-app]

Overview

Octane AI analysis has finished. No vulnerabilities were found. Cheers! 🎉🎉🎉

---

🔗 Commit Hash: f6b20c4

[github-actions]

Coverage after merging dev-1150-fix-weethModule into dev will be

99.40%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
deploy
ControllerDeploy.sol	100%	100%	100%	100%
ForeignControllerInit.sol	100%	100%	100%	100%
MainnetControllerInit.sol	97.37%	93.33%	100%	100%	152, 90
src
ALMProxy.sol	100%	100%	100%	100%
ALMProxyFreezable.sol	100%	100%	100%	100%
ForeignController.sol	95.18%	87.50%	95.65%	97.30%	128–129, 129, 129, 316–317, 579
MainnetController.sol	99.18%	100%	98.36%	99.24%	596–597
OTCBuffer.sol	100%	100%	100%	100%
RateLimitHelpers.sol	100%	100%	100%	100%
RateLimits.sol	100%	100%	100%	100%
WEETHModule.sol	92.86%	75%	100%	100%	29, 41
src/libraries
AaveLib.sol	100%	100%	100%	100%
ApproveLib.sol	100%	100%	100%	100%
CCTPLib.sol	100%	100%	100%	100%
CurveLib.sol	100%	100%	100%	100%
ERC4626Lib.sol	97.06%	90%	100%	100%	117
LayerZeroLib.sol	100%	100%	100%	100%
PSMLib.sol	100%	100%	100%	100%
UniswapV4Lib.sol	99.32%	95.65%	100%	100%	282
WEETHLib.sol	100%	100%	100%	100%