fix: Get quote from ALM Proxy (DEV-1141)

[supercontracts]

Summary by CodeRabbit

• Refactor
  • Improved internal quote handling mechanism to enhance code organization and maintainability. The system now uses a more structured architecture for processing quote-related operations and data handling.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[notion-workspace]

Update LZ quoting to come from ALMProxy not controller

[octane-security-app]

Summary by Octane

New Contracts

No new contracts were added.

Updated Contracts

• LayerZeroLib.sol: The smart contract updates enhance LayerZero integration by adding detailed OFT limit and fee parameters.

---

🔗 Commit Hash: 6fb04d5

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

Walkthrough

LayerZeroLib.sol is modified to replace a direct quoteOFT call with a proxy-based approach using proxy.doCall and abi.encodeCall. The result is explicitly decoded into OFTLimit, OFTFeeDetail[], and OFTReceipt components, with minAmountLD assignment updated to derive from the decoded receipt.

Changes

Cohort / File(s)	Summary
LayerZero Proxy Call Refactor src/libraries/LayerZeroLib.sol	Added imports for OFTLimit, OFTFeeDetail, IRateLimits, and IALMProxy. Replaced direct quoteOFT call with proxy.doCall using abi.encodeCall, explicitly decoding result as (OFTLimit, OFTFeeDetail[], OFTReceipt). Updated minAmountLD assignment to use decoded OFTReceipt instead of direct return value.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• refactor: LayerZero #216 — Main PR's changes to LayerZeroLib.sol directly modify the same quote/fee retrieval logic, switching from direct calls to proxy.doCall pattern with explicit decoding.

Suggested reviewers

• lucas-manuel
• deluca-mike

Poem

🐰 A proxy path we hop along,
Where quoteOFT calls now belong,
Decoded receipts, fees unfold,
Layer by layer, stories told! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title follows the required format with a type prefix and colon, is concise and descriptive, and accurately reflects the main change of retrieving quotes through an ALM Proxy with the associated JIRA key.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch dev-1141-quote-from-almProxy

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• DEV-1141: Entity not found: Issue - Could not find referenced Issue.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Coverage after merging dev-1141-quote-from-almProxy into dev will be

99.40%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
deploy
ControllerDeploy.sol	100%	100%	100%	100%
ForeignControllerInit.sol	100%	100%	100%	100%
MainnetControllerInit.sol	97.37%	93.33%	100%	100%	152, 90
src
ALMProxy.sol	100%	100%	100%	100%
ALMProxyFreezable.sol	100%	100%	100%	100%
ForeignController.sol	94.90%	84.62%	95.65%	97.22%	128–129, 129, 129, 316–317, 573
MainnetController.sol	99.18%	100%	98.36%	99.24%	593–594
OTCBuffer.sol	100%	100%	100%	100%
RateLimitHelpers.sol	100%	100%	100%	100%
RateLimits.sol	100%	100%	100%	100%
WEETHModule.sol	92.86%	75%	100%	100%	26, 38
src/libraries
AaveLib.sol	100%	100%	100%	100%
ApproveLib.sol	100%	100%	100%	100%
CCTPLib.sol	100%	100%	100%	100%
CurveLib.sol	100%	100%	100%	100%
ERC4626Lib.sol	96%	75%	100%	100%	108
LayerZeroLib.sol	100%	100%	100%	100%
PSMLib.sol	100%	100%	100%	100%
UniswapV4Lib.sol	99.32%	95.65%	100%	100%	282
WEETHLib.sol	100%	100%	100%	100%

[octane-security-app]

Overview

Vulnerabilities found:	2

---

🔗 Commit Hash: 6fb04d5
🛡️ Octane Dashboard: All vulnerabilities