feat: Use LayerZeroLib in Foreign Controller (DEV-1142)

[supercontracts]

Summary by CodeRabbit

• Refactor
  • Consolidated LayerZero token transfer logic into a dedicated library for improved code organization and maintainability
  • Streamlined transfer process with simplified error messaging

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[notion-workspace]

Update ForeignController to use LayerZeroLib

[octane-security-app]

Summary by Octane

New Contracts

No new contracts were added.

Updated Contracts

• ForeignController.sol: Integrated LayerZeroLib for LayerZero transfer functionality, centralizing logic and simplifying the contract.
• LayerZeroLib.sol: Removed "MC/" prefix in error message string for recipient-not-set.

---

🔗 Commit Hash: 9e972e1

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

Walkthrough

The pull request refactors LayerZero token transfer functionality by consolidating logic from ForeignController into LayerZeroLib. In-contract transfer operations are replaced with a single library call, and the LIMIT_LAYERZERO_TRANSFER constant now references the library's definition. Associated test expectations are updated to reflect simplified error messages.

Changes

Cohort / File(s)	Summary
ForeignController refactoring src/ForeignController.sol	Replaced in-contract LayerZero transfer logic with LayerZeroLib.transferTokenLayerZero call; removed per-call rate-limiting and preparation steps; updated LIMIT_LAYERZERO_TRANSFER to source from library constant.
Library and test updates src/libraries/LayerZeroLib.sol, test/mainnet-fork/LayerZero.t.sol	Simplified error message from "MC/recipient-not-set" and "FC/recipient-not-set" to generic "recipient-not-set" across library and test expectations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• refactor: LayerZero #216: Performs identical LayerZero logic consolidation using LayerZeroLib, updating LIMIT_LAYERZERO_TRANSFER references and error strings.
• feat: Update ForeignController to use modifiers (SC-1281) #201: Modifies ForeignController's rate-limiting approach for LayerZero transfers.
• feat: Remove shadow declaration warning and add zero address check (SC-1277) #200: Adjusts LayerZero recipient validation logic in ForeignController's transfer handling.

Suggested reviewers

• deluca-mike
• lucas-manuel

Poem

🐰 Hops through code with glee!
Logic bundled, clean and free,
Library calls sing sweet and clear,
Transfer flows—no more to fear!
✨ Consolidation magic here! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: integrating LayerZeroLib into the ForeignController contract, and includes the JIRA key (DEV-1142) as required.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch dev-1142-fc-use-lzlib

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

• DEV-1142: Entity not found: Issue - Could not find referenced Issue.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[octane-security-app]

Overview

Vulnerabilities found:	2

---

🔗 Commit Hash: 9e972e1
🛡️ Octane Dashboard: All vulnerabilities

[lucas-manuel]

"LayerZeroLib/recipient-not-set"

[supercontracts]

changed

[github-actions]

Coverage after merging dev-1142-fc-use-lzlib into dev will be

99.52%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
deploy
ControllerDeploy.sol	100%	100%	100%	100%
ForeignControllerInit.sol	100%	100%	100%	100%
MainnetControllerInit.sol	97.37%	93.33%	100%	100%	152, 90
src
ALMProxy.sol	100%	100%	100%	100%
ALMProxyFreezable.sol	100%	100%	100%	100%
ForeignController.sol	96.08%	89.66%	95.65%	98.02%	130–131, 131, 131, 551
MainnetController.sol	99.18%	100%	98.36%	99.24%	596–597
OTCBuffer.sol	100%	100%	100%	100%
RateLimitHelpers.sol	100%	100%	100%	100%
RateLimits.sol	100%	100%	100%	100%
WEETHModule.sol	92.86%	75%	100%	100%	29, 41
src/libraries
AaveLib.sol	100%	100%	100%	100%
ApproveLib.sol	100%	100%	100%	100%
CCTPLib.sol	100%	100%	100%	100%
CurveLib.sol	100%	100%	100%	100%
ERC4626Lib.sol	97.06%	90%	100%	100%	117
LayerZeroLib.sol	100%	100%	100%	100%
PSMLib.sol	100%	100%	100%	100%
UniswapV4Lib.sol	99.32%	95.65%	100%	100%	282
WEETHLib.sol	100%	100%	100%	100%