fix: CLOSE_CURRENCY instead of SETTLE_PAIR (DEV-1229)

[deluca-mike]

Summary by CodeRabbit

• Refactor
  • Optimized currency handling in liquidity modification operations for improved efficiency.

[octane-security-app]

Summary by Octane

New Contracts

No new contracts were added.

Updated Contracts

• UniswapV4Lib.sol: The smart contract changes close currencies instead of settling pairs and adjust parameter encoding.

---

🔗 Commit Hash: 18fc251

[notion-workspace]

Uniswap V4 increaseLiquidity could use CLOSE_CURRENCY instead of SETTLE_PAIR

[coderabbitai]

Walkthrough

The changes modify UniswapV4Lib.sol to replace a single SETTLE_PAIR action with two CLOSE_CURRENCY actions in liquidity mint and increase operations, and expand modify-liquidity parameters from 2 to 3 entries by splitting combined currencies into separate currency0 and currency1 parameters. The control flow remains unchanged.

Changes

Cohort / File(s)	Summary
UniswapV4Lib Parameter Refactoring src/libraries/UniswapV4Lib.sol	Replaces SETTLE_PAIR action with two CLOSE_CURRENCY actions in mint/increase liquidity paths; expands modify-liquidity parameters from 2 to 3 entries, separating currency pair into individual currency0 and currency1 parameters.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• fix: Use Actions.CLOSE_CURRENCY for increase liquidity #226 — Makes the identical code-level changes in UniswapV4Lib.sol, replacing SETTLE_PAIR with dual CLOSE_CURRENCY actions and expanding params.
• fix: Inconsistent Uniswap v4 PositionManager action usage in increasePosition #204 — Introduces inverse/conflicting changes to the same file, consolidating currencies and shrinking parameters in the opposite direction.

Suggested reviewers

• lucas-manuel
• TheMj0ln1r

Poem

🐰 A pair that once settled as one,
Now splits into two—what fun!
CLOSE_CURRENCY calls abound,
Parameters expanded, currencies unbound! 🌊

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: CLOSE_CURRENCY instead of SETTLE_PAIR (DEV-1229)' follows the required format (prefix: colon) and clearly describes the main change in the pull request.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch refactor/dev-1229-close-currency

---

No actionable comments were generated in the recent review. 🎉

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Coverage after merging refactor/dev-1229-close-currency into dev will be

99.30%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
deploy
ControllerDeploy.sol	100%	100%	100%	100%
ForeignControllerInit.sol	100%	100%	100%	100%
MainnetControllerInit.sol	97.37%	93.33%	100%	100%	152, 90
src
ALMProxy.sol	100%	100%	100%	100%
ALMProxyFreezable.sol	100%	100%	100%	100%
ForeignController.sol	96.10%	89.66%	95.65%	98.04%	130–131, 131, 131, 556
MainnetController.sol	99.20%	100%	98.39%	99.25%	614–615
OTCBuffer.sol	92.31%	100%	83.33%	93.75%	55
RateLimitHelpers.sol	100%	100%	100%	100%
RateLimits.sol	100%	100%	100%	100%
WEETHModule.sol	93.18%	90%	85.71%	96.30%	65, 72
src/libraries
AaveLib.sol	100%	100%	100%	100%
ApproveLib.sol	100%	100%	100%	100%
CCTPLib.sol	100%	100%	100%	100%
CurveLib.sol	100%	100%	100%	100%
ERC4626Lib.sol	97.06%	90%	100%	100%	117
LayerZeroLib.sol	100%	100%	100%	100%
PSMLib.sol	100%	100%	100%	100%
UniswapV4Lib.sol	99.33%	95.65%	100%	100%	282
WEETHLib.sol	100%	100%	100%	100%

[octane-security-app]

Overview

Vulnerabilities found:	1

Warnings found:	1

---

🔗 Commit Hash: 18fc251
🛡️ Octane Dashboard: All vulnerabilities