Merged
Conversation
lucas-manuel
requested changes
Sep 17, 2025
lucas-manuel
requested changes
Sep 25, 2025
lucas-manuel
requested changes
Sep 29, 2025
Comment on lines
90
to
106
| function queueSourceToDestination(bytes memory message) internal override { | ||
| // Gas to queue message | ||
| vm.deal(sourceAuthority, 1 ether); | ||
| deal(lzToken, sourceAuthority, 1 ether); | ||
|
|
||
| bytes memory options = OptionsBuilder.newOptions().addExecutorLzReceiveOption(200_000, 0); | ||
|
|
||
| LZForwarder.sendMessage( | ||
| destinationEndpointId, | ||
| bytes32(uint256(uint160(destinationReceiver))), | ||
| ILayerZeroEndpointV2(bridge.sourceCrossChainMessenger), | ||
| message, | ||
| options, | ||
| sourceAuthority, | ||
| true | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
Add assertions
function queueSourceToDestination(bytes memory message) internal override {
// Gas to queue message
vm.deal(sourceAuthority, 1 ether);
deal(lzToken, sourceAuthority, 1 ether);
bytes memory options = OptionsBuilder.newOptions().addExecutorLzReceiveOption(200_000, 0);
assertEq(IERC20(lzToken).balanceOf(address(sourceAuthority)), 1 ether);
assertEq(address(sourceAuthority).balance, 1 ether);
LZForwarder.sendMessage(
destinationEndpointId,
bytes32(uint256(uint160(destinationReceiver))),
ILayerZeroEndpointV2(bridge.sourceCrossChainMessenger),
message,
options,
sourceAuthority,
true
);
// LZ token and ETH spent
assertLt(IERC20(lzToken).balanceOf(address(sourceAuthority)), 1 ether);
assertLt(address(sourceAuthority).balance, 1 ether);
}
|
Coverage after merging fix/sc-1152 into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
lucas-manuel
approved these changes
Sep 29, 2025
barrutko
added a commit
to grove-labs/xchain-helpers
that referenced
this pull request
Oct 14, 2025
* feat: Add LayerZero Support (SC-1050) (sparkdotfi#37) * intial commit * fix: tests add: binance chain * add: init * fix * Update LZReceiver.sol * fix: receiver * add: LZReceiver.t.sol * fix: review * fix: LZForwarder refund correct payer (SC-1127) (sparkdotfi#39) * fix: Use address(this) as sender in quote in LZForwarder (SC-1126) (sparkdotfi#38) Co-authored-by: Lucas Manuel <lucasmanuel.tech@gmail.com> * fix: `LZReceiver` implement full OApp (SC-1124, SC-1125) (sparkdotfi#40) * save * fix: review * fix: review * fix: comment * fix: Pay in LZToken (SC-1152) (sparkdotfi#41) * fix * add: param * add: tests * fix: review * feat: Add Avalanche to lz (SC-1178) (sparkdotfi#43) --------- Co-authored-by: supercontracts <bonjour.tabish@gmail.com> Co-authored-by: Lucas Manuel <lucasmanuel.tech@gmail.com>
barrutko
added a commit
to grove-labs/xchain-helpers
that referenced
this pull request
Oct 14, 2025
* feat: Add LayerZero Support (SC-1050) (sparkdotfi#37) * intial commit * fix: tests add: binance chain * add: init * fix * Update LZReceiver.sol * fix: receiver * add: LZReceiver.t.sol * fix: review * fix: LZForwarder refund correct payer (SC-1127) (sparkdotfi#39) * fix: Use address(this) as sender in quote in LZForwarder (SC-1126) (sparkdotfi#38) * fix: `LZReceiver` implement full OApp (SC-1124, SC-1125) (sparkdotfi#40) * save * fix: review * fix: review * fix: comment * fix: Pay in LZToken (SC-1152) (sparkdotfi#41) * fix * add: param * add: tests * fix: review * feat: Add Avalanche to lz (SC-1178) (sparkdotfi#43) --------- Co-authored-by: supercontracts <bonjour.tabish@gmail.com> Co-authored-by: Lucas Manuel <lucasmanuel.tech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.