Improve warning reports for known settings (but not supported on platform)

Author: nseidle

Firmware/RTK_Everywhere/menuCommands.ino

@@ -1587,10 +1587,12 @@ SettingValueResponse updateSettingWithValue(bool inCommands, const char *setting
     }
 
     // Unused variables from the Web Config interface - read to avoid errors
-    else
+    // Check if this setting an unused element from the Web Config interface
+    if (knownSetting == false)
     {
         const char *table[] = {
             "baseTypeSurveyIn",
+            "enableAutoReset",
             "enableFactoryDefaults",
             "enableFirmwareUpdate",
             "enableForgetRadios",
@@ -1601,15 +1603,20 @@ SettingValueResponse updateSettingWithValue(bool inCommands, const char *setting
             "nicknameECEF",
             "nicknameGeodetic",
             "saveToArduino",
-            "enableAutoReset",
             "shutdownNoChargeTimeoutMinutesCheckbox",
         };
         const int tableEntries = sizeof(table) / sizeof(table[0]);
 
-        knownSetting = commandCheckListForVariable(settingName, table, tableEntries);
+        // Compare the above table against this settingName
+        if (commandCheckListForVariable(settingName, table, tableEntries))
+        {
+            if (settings.debugWebServer == true)
+                systemPrintf("Setting '%s' is known web interface element. Ignoring.\r\n", settingName);
+            return (SETTING_KNOWN_WEB_CONFIG_INTERFACE_ELEMENT);
+        }
     }
 
-    // Check if this setting is read only
+    // Check if this setting is read only. Used with the CLI.
     if (knownSetting == false)
     {
         const char *table[] = {
@@ -1626,19 +1633,11 @@ SettingValueResponse updateSettingWithValue(bool inCommands, const char *setting
         };
         const int tableEntries = sizeof(table) / sizeof(table[0]);
 
+        // Compare the above table against this settingName
         if (commandCheckListForVariable(settingName, table, tableEntries))
             return (SETTING_KNOWN_READ_ONLY);
     }
 
-    // If we've received a setting update for a setting that is not valid to this platform,
-    // allow it, but throw a warning.
-    // This is often caused by the Web Config page reporting all cells including
-    // those that are hidden because of platform limitations
-    if (knownSetting == true && settingAvailableOnPlatform(i) == false)
-    {
-        systemPrintf("Setting '%s' stored but not supported on this platform\r\n", settingName);
-    }
-
     // Last catch
     if (knownSetting == false)
     {
@@ -1685,6 +1684,16 @@ SettingValueResponse updateSettingWithValue(bool inCommands, const char *setting
         rtkFree(name, "name & suffix buffers");
     }
 
+    // If we've received a setting update for a setting that is not valid to this platform,
+    // allow it, but throw a warning.
+    // This is often caused by the Web Config page reporting all cells including
+    // those that are hidden because of platform limitations
+    if (knownSetting == false && rtkSettingsEntries[i].inWebConfig && (settingAvailableOnPlatform(i) == false))
+    {
+        if (settings.debugWebServer == true)
+            systemPrintf("Setting '%s' received but not supported on this platform\r\n", settingName);
+    }
+
     if (knownSetting == true && settingIsString == true)
         return (SETTING_KNOWN_STRING);
     else if (knownSetting == true)

Firmware/RTK_Everywhere/settings.h

@@ -553,6 +553,7 @@ typedef enum
     SETTING_KNOWN,
     SETTING_KNOWN_STRING,
     SETTING_KNOWN_READ_ONLY,
+    SETTING_KNOWN_WEB_CONFIG_INTERFACE_ELEMENT,
 } SettingValueResponse;
 
 #define INCHES_IN_A_METER   39.37007874