Exit config mode before saving

Author: nseidle

Firmware/RTK_Everywhere/GNSS_LG290P.ino

@@ -229,6 +229,8 @@ bool GNSS_LG290P::configureOnce()
 
     // We do not set Rover or fix rate here because fix rate only applies in rover mode.
 
+    response &= exitConfigMode(); // We must exit config before we save otherwise we will save with NMEA/RTCM off
+
     if (response)
     {
         online.gnss = true; // If we failed before, mark as online now
@@ -244,8 +246,6 @@ bool GNSS_LG290P::configureOnce()
     else
         online.gnss = false; // Take it offline
 
-    exitConfigMode();
-
     return (response);
 }
 
@@ -298,6 +298,8 @@ bool GNSS_LG290P::configureRover()
     if (settings.debugGnss && response == false)
         systemPrintln("Rover: Enable NMEA failed");
 
+    response &= exitConfigMode(); // We must exit config before we save otherwise we will save with NMEA/RTCM off
+
     if (response == false)
     {
         systemPrintln("LG290P Rover failed to configure");
@@ -314,8 +316,6 @@ bool GNSS_LG290P::configureRover()
             systemPrintln("LG290P Rover configured");
     }
 
-    exitConfigMode();
-
     return (response);
 }
 
@@ -385,6 +385,8 @@ bool GNSS_LG290P::configureBase()
     if (settings.debugGnss && response == false)
         systemPrintln("Base: Enable NMEA failed");
 
+    response &= exitConfigMode(); // We must exit config before we save otherwise we will save with NMEA/RTCM off
+
     if (response == false)
     {
         systemPrintln("LG290P Base failed to configure");
@@ -397,12 +399,12 @@ bool GNSS_LG290P::configureBase()
         if (settingsWereSaved)
             settings.updateGNSSSettings = false;
 
+        softwareReset();
+
         if (settings.debugGnss)
             systemPrintln("LG290P Base configured");
     }
 
-    exitConfigMode();
-
     return (response);
 }