Make beeper follow settings at power on.

Settings must be loaded before beeper is used.

Author: nseidle

Firmware/RTK_Everywhere/Begin.ino

@@ -249,13 +249,6 @@ void beginBoard()
         batteryStatusLedOn();
 
         pinMode(pin_beeper, OUTPUT);
-
-        // Beep at power on if we are not locally compiled or a release candidate
-        if (ENABLE_DEVELOPER == false)
-        {
-            beepOn();
-            delay(250);
-        }
         beepOff();
 
         pinMode(pin_powerButton, INPUT);
@@ -282,7 +275,7 @@ void beginBoard()
         loraPowerOff(); // Keep LoRa powered down for now
 
         pinMode(pin_loraRadio_boot, OUTPUT);
-        digitalWrite(pin_loraRadio_boot, LOW); //Exit bootloader, run program
+        digitalWrite(pin_loraRadio_boot, LOW); // Exit bootloader, run program
 
         pinMode(pin_loraRadio_reset, OUTPUT);
         digitalWrite(pin_loraRadio_reset, LOW); // Reset STM32/radio
@@ -924,6 +917,14 @@ void tickerBegin()
         beepTask.detach();                                          // Turn off any previous task
         beepTask.attach(1.0 / beepTaskUpdatesHz, tickerBeepUpdate); // Rate in seconds, callback
     }
+
+    // Beep at power on if we are not locally compiled or a release candidate
+    // if (ENABLE_DEVELOPER == false)
+    {
+        beepOn();
+        delay(250);
+    }
+    beepOff();
 }
 
 // Stop any ticker tasks and PWM control

Firmware/RTK_Everywhere/RTK_Everywhere.ino

@@ -1032,6 +1032,13 @@ void setup()
     DMW_b("beginFS");
     beginFS(); // Start the LittleFS file system in the spiffs partition
 
+    // At this point product variants are known, except early RTK products that lacked ID resistors
+    DMW_b("loadSettingsPartial");
+    loadSettingsPartial(); // Must be after the product variant is known so the correct setting file name is loaded.
+
+    DMW_b("tickerBegin");
+    tickerBegin(); // Start ticker tasks for LEDs and beeper
+
     DMW_b("checkUpdateLoraFirmware");
     if (checkUpdateLoraFirmware() == true) // Check if updateLoraFirmware.txt exists
         beginLoraFirmwareUpdate();
@@ -1044,10 +1051,6 @@ void setup()
     configureViaEthernet =
         checkConfigureViaEthernet(); // Check if going into dedicated configureViaEthernet (STATE_CONFIG_VIA_ETH) mode
 
-    // At this point product variants are known, except early RTK products that lacked ID resistors
-    DMW_b("loadSettingsPartial");
-    loadSettingsPartial(); // Must be after the product variant is known so the correct setting file name is loaded.
-
     DMW_b("beginPsram");
     beginPsram(); // Inialize PSRAM (if available). Needs to occur before beginGnssUart and other malloc users.
 
@@ -1076,9 +1079,6 @@ void setup()
     DMW_b("displaySplash");
     displaySplash(); // Display the RTK product name and firmware version
 
-    DMW_b("tickerBegin");
-    tickerBegin(); // Start ticker tasks for LEDs and beeper
-
     DMW_b("beginSD");
     beginSD(); // Requires settings. Test if SD is present
 

Firmware/RTK_Everywhere/support.ino

@@ -477,6 +477,7 @@ const double WGS84_A = 6378137;           // https://geographiclib.sourceforge.i
 const double WGS84_E = 0.081819190842622; // http://docs.ros.org/en/hydro/api/gps_common/html/namespacegps__common.html
                                           // and https://gist.github.com/uhho/63750c4b54c7f90f37f958cc8af0c718
 
+// Convert LLH (geodetic) to ECEF
 // From: https://stackoverflow.com/questions/19478200/convert-latitude-and-longitude-to-ecef-coordinates-system
 void geodeticToEcef(double lat, double lon, double alt, double *x, double *y, double *z)
 {
@@ -492,6 +493,7 @@ void geodeticToEcef(double lat, double lon, double alt, double *x, double *y, do
     *z = (N * (1.0 - WGS84_E * WGS84_E) + alt) * slat;
 }
 
+// Convert ECEF to LLH (geodetic)
 // From: https://danceswithcode.net/engineeringnotes/geodetic_to_ecef/geodetic_to_ecef.html
 void ecefToGeodetic(double x, double y, double z, double *lat, double *lon, double *alt)
 {