Gemfile: add ruby RUBY_VERSION version hint#18
Open
olleolleolle wants to merge 2 commits intosparklemotion:masterfrom
Open
Gemfile: add ruby RUBY_VERSION version hint#18olleolleolle wants to merge 2 commits intosparklemotion:masterfrom
olleolleolle wants to merge 2 commits intosparklemotion:masterfrom
Conversation
Author
|
Member
|
It was an accident that 1.8 compatibility was broken, http-cookie still supports 1.8. |
Author
|
@knu Cool!
|
Author
|
Perhaps we can talk about whether to keep rbx-2 in the matrix, instead? |
Member
|
@olleolleolle I think we can drop support for rbx-2. |
knu
reviewed
Feb 20, 2017
.travis.yml
Outdated
| - jruby-1.7 | ||
| - jruby-9 | ||
| - jruby-1.7.26 | ||
| - jruby-9.1.6.0 |
Member
There was a problem hiding this comment.
Do we need this change? I don't like to hard-code minor versions. For jruby-9.1.x you could just say jruby, if jruby-9 pointed to jruby-9.0.x.
knu
reviewed
Feb 20, 2017
| source 'https://rubygems.org' | ||
|
|
||
| # Specify your gem's dependencies in http-cookie.gemspec | ||
| ruby RUBY_VERSION |
Member
There was a problem hiding this comment.
Maybe I could just merge this part, since that's what this PR is about.
Author
There was a problem hiding this comment.
I removed the other changes; would this make it mergeable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Until Bundler can figure all of this out on its own, we can regenerate the lockfile on each build.)