Bugfix - Code generation with fields called value (#619)

* fix the template

* add a test case in schema

* regen generated code

* changelog

Author: jamiebrynes7

CHANGELOG.md

@@ -15,6 +15,10 @@
 - Improved the method of calculating load and FPS.
 - Updated test project Unity version to `2018.2.14f`.
 
+### Fixed
+
+- Fixed a bug where schema components with a field named `value` would generate invalid code.
+
 ## `0.1.2` - 2018-11-01
 
 ### Added

test-project/Assets/.Schema/improbable/gdk/tests/alternate_schema_syntax.schema

@@ -1,7 +1,7 @@
 package improbable.gdk.tests.alternate_schema_syntax;
 
 type RandomDataType {
-
+    int32 value = 1;
 }
 
 component Connection

test-project/Assets/Generated/Source/improbable/gdk/tests/ExhaustiveBlittableSingular.cs

@@ -115,7 +115,7 @@ public BlittableBool Field1
                 set
                 {
                     MarkDataDirty(0);
-                    field1 = value;
+                    this.field1 = value;
                 }
             }
 
@@ -127,7 +127,7 @@ public float Field2
                 set
                 {
                     MarkDataDirty(1);
-                    field2 = value;
+                    this.field2 = value;
                 }
             }
 
@@ -139,7 +139,7 @@ public int Field4
                 set
                 {
                     MarkDataDirty(2);
-                    field4 = value;
+                    this.field4 = value;
                 }
             }
 
@@ -151,7 +151,7 @@ public long Field5
                 set
                 {
                     MarkDataDirty(3);
-                    field5 = value;
+                    this.field5 = value;
                 }
             }
 
@@ -163,7 +163,7 @@ public double Field6
                 set
                 {
                     MarkDataDirty(4);
-                    field6 = value;
+                    this.field6 = value;
                 }
             }
 
@@ -175,7 +175,7 @@ public uint Field8
                 set
                 {
                     MarkDataDirty(5);
-                    field8 = value;
+                    this.field8 = value;
                 }
             }
 
@@ -187,7 +187,7 @@ public ulong Field9
                 set
                 {
                     MarkDataDirty(6);
-                    field9 = value;
+                    this.field9 = value;
                 }
             }
 
@@ -199,7 +199,7 @@ public int Field10
                 set
                 {
                     MarkDataDirty(7);
-                    field10 = value;
+                    this.field10 = value;
                 }
             }
 
@@ -211,7 +211,7 @@ public long Field11
                 set
                 {
                     MarkDataDirty(8);
-                    field11 = value;
+                    this.field11 = value;
                 }
             }
 
@@ -223,7 +223,7 @@ public uint Field12
                 set
                 {
                     MarkDataDirty(9);
-                    field12 = value;
+                    this.field12 = value;
                 }
             }
 
@@ -235,7 +235,7 @@ public ulong Field13
                 set
                 {
                     MarkDataDirty(10);
-                    field13 = value;
+                    this.field13 = value;
                 }
             }
 
@@ -247,7 +247,7 @@ public int Field14
                 set
                 {
                     MarkDataDirty(11);
-                    field14 = value;
+                    this.field14 = value;
                 }
             }
 
@@ -259,7 +259,7 @@ public long Field15
                 set
                 {
                     MarkDataDirty(12);
-                    field15 = value;
+                    this.field15 = value;
                 }
             }
 
@@ -271,7 +271,7 @@ public long Field15
                 set
                 {
                     MarkDataDirty(13);
-                    field16 = value;
+                    this.field16 = value;
                 }
             }
 
@@ -283,7 +283,7 @@ public long Field15
                 set
                 {
                     MarkDataDirty(14);
-                    field17 = value;
+                    this.field17 = value;
                 }
             }
 

test-project/Assets/Generated/Source/improbable/gdk/tests/ExhaustiveSingular.cs

@@ -123,7 +123,7 @@ public BlittableBool Field1
                 set
                 {
                     MarkDataDirty(0);
-                    field1 = value;
+                    this.field1 = value;
                 }
             }
 
@@ -135,7 +135,7 @@ public float Field2
                 set
                 {
                     MarkDataDirty(1);
-                    field2 = value;
+                    this.field2 = value;
                 }
             }
 
@@ -159,7 +159,7 @@ public int Field4
                 set
                 {
                     MarkDataDirty(3);
-                    field4 = value;
+                    this.field4 = value;
                 }
             }
 
@@ -171,7 +171,7 @@ public long Field5
                 set
                 {
                     MarkDataDirty(4);
-                    field5 = value;
+                    this.field5 = value;
                 }
             }
 
@@ -183,7 +183,7 @@ public double Field6
                 set
                 {
                     MarkDataDirty(5);
-                    field6 = value;
+                    this.field6 = value;
                 }
             }
 
@@ -207,7 +207,7 @@ public uint Field8
                 set
                 {
                     MarkDataDirty(7);
-                    field8 = value;
+                    this.field8 = value;
                 }
             }
 
@@ -219,7 +219,7 @@ public ulong Field9
                 set
                 {
                     MarkDataDirty(8);
-                    field9 = value;
+                    this.field9 = value;
                 }
             }
 
@@ -231,7 +231,7 @@ public int Field10
                 set
                 {
                     MarkDataDirty(9);
-                    field10 = value;
+                    this.field10 = value;
                 }
             }
 
@@ -243,7 +243,7 @@ public long Field11
                 set
                 {
                     MarkDataDirty(10);
-                    field11 = value;
+                    this.field11 = value;
                 }
             }
 
@@ -255,7 +255,7 @@ public uint Field12
                 set
                 {
                     MarkDataDirty(11);
-                    field12 = value;
+                    this.field12 = value;
                 }
             }
 
@@ -267,7 +267,7 @@ public ulong Field13
                 set
                 {
                     MarkDataDirty(12);
-                    field13 = value;
+                    this.field13 = value;
                 }
             }
 
@@ -279,7 +279,7 @@ public int Field14
                 set
                 {
                     MarkDataDirty(13);
-                    field14 = value;
+                    this.field14 = value;
                 }
             }
 
@@ -291,7 +291,7 @@ public long Field15
                 set
                 {
                     MarkDataDirty(14);
-                    field15 = value;
+                    this.field15 = value;
                 }
             }
 
@@ -303,7 +303,7 @@ public long Field15
                 set
                 {
                     MarkDataDirty(15);
-                    field16 = value;
+                    this.field16 = value;
                 }
             }
 
@@ -315,7 +315,7 @@ public long Field15
                 set
                 {
                     MarkDataDirty(16);
-                    field17 = value;
+                    this.field17 = value;
                 }
             }
 

test-project/Assets/Generated/Source/improbable/gdk/tests/NestedComponent.cs

@@ -107,7 +107,7 @@ public Snapshot ToComponentSnapshot(global::Unity.Entities.World world)
                 set
                 {
                     MarkDataDirty(0);
-                    nestedType = value;
+                    this.nestedType = value;
                 }
             }