Use connection name from QueryException when creating QueryExecuted event#405
Open
oli-laban wants to merge 1 commit intospatie:mainfrom
Open
Use connection name from QueryException when creating QueryExecuted event#405oli-laban wants to merge 1 commit intospatie:mainfrom
QueryException when creating QueryExecuted event#405oli-laban wants to merge 1 commit intospatie:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a multi-tenant / multi-DB application which has no default connection as it is resolved at request time. Various things like Commands use
DB::usingConnection()to temporarily set a default connection, but exceptions cascade back out of this callback and by the time Ray processes it, there is no default. This causes an exception asnullgets passed toDB::connection(), which masks the original exception and is very annoying.QueryExceptionholds the connection name so I've simply updated it to use that. It falls back to the default as the property was added in Laravel 10.x and Ray looks to support back to 7.x.There are currently no tests covering
QueryExceptions so I haven't added any for this minor change. I can look into covering that path if needed.