Improve readability of generated JSON snapshots #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostrolucky
force-pushed
the
prettier-json
branch
from
f11e8c3 to
1a2fb51
Compare
Member
|
Nice, but merging this now would make all existing snapshot tests fail. We'll take a look again when tagging a new major version. |
Contributor
Author
|
How would it fail existing snapshot tests? You don't check contents literal. You json_decode() first and compare arrays. Result of json_decode() before and after my changes is still same. |
Member
Ah, you are correct... |
Member
|
Thanks! |
Contributor
Author
|
You are welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have lot of snapshots containing links. I am sure it will be much easier to read them if they are unescaped. Most languages do not do these escapings by default, PHP does it because of some security-wise XSS edge cases that are not relevant here.