Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the issue I previously already, here is an implementation of named snapshots, option 2.
Having the option to use explicitly named IDs for snapshots allows one to avoid needing read confusing diffs when a test is refactored (see the issue for an example).
This PR implements the following changes:
SnapshotIdAwareconcern. It makes sense to have it here, rather than inMatchesSnapshots, so getting an ID and incrementing are all a single operation.$idargument to all the assertions. The retains backwards compatibility, while allowing explicit IDs to be used when required.$idis populated, this is used to name the snapshot, instead of the next incrementor value. It is also prefixed withs-to avoid the possibility of conflicts with incrementor values.$idargument set.