Skip to content

Feature/guidelines design#379

Open
NickBevers wants to merge 12 commits intomainfrom
feature/guidelines-design
Open

Feature/guidelines design#379
NickBevers wants to merge 12 commits intomainfrom
feature/guidelines-design

Conversation

@NickBevers
Copy link

No description provided.

@NickBevers NickBevers force-pushed the feature/guidelines-design branch from 91dce94 to c8e63cc Compare January 21, 2026 13:07
@NickBevers NickBevers marked this pull request as ready for review January 22, 2026 07:02
@sebastiandedeyne
Copy link
Member

sebastiandedeyne commented Feb 23, 2026

Content changes summary:

Split "Laravel & PHP" into two separate pages

The single laravel-php.md page has been split into:

  • php.md (weight 1) — PHP-specific guidelines
  • laravel.md (weight 2) — Laravel-specific guidelines

New content in php.md

final and readonly stance expanded — The old single-line statement about not using final has been expanded to cover readonly as well:

  • final: Same reasoning as before (not much benefit, team doesn't rely on inheritance)
  • readonly: Not worth the extra keyword; context (e.g. DTOs, resources) already makes read-only intent clear

New "Class constants" section — Class constants should follow PascalCase (same rule as enums), e.g. Session::SessionTokenHeader.

@jimirobaer
Copy link
Member

Added small styling tweaks (font size, responsive tweak) and fixed two SVGs (strokes not being outlined made they appear look weird). Other than that, lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants