-
-
Notifications
You must be signed in to change notification settings - Fork 43
v3 #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
v3 #62
Conversation
@rubenvanassche has this been abandoned? Do you think I can PR back something that fixes #23 in v2? I am still using this writer in all my projects to this day 🥲 final class OptionalPropertiesTypeDefinitionWriter extends TypeDefinitionWriter
{
public function format(TypesCollection $collection): string
{
return str(parent::format($collection))
->replaceMatches('/(\w+)\??: ([\w\. |<>]+) \| null;/', function ($matches) {
return \sprintf('%s?: %s', $matches[1], $matches[2]);
})
->toString();
}
} |
Not abandonned, just a lot of other things I'm working on internally which makes it complicated to work on this. As for your PR, @sebastiandedeyne will take a look at what such changes would mean for our projects and if it would be useful. |
Thanks for the answer @rubenvanassche! |
Thank you for your huge efforts! |
Dear contributor, because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it. |
This is all work in progress - a complete rewrite of ts transformer