Promoted properties support #90
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear contributor, because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it. |
Comment on lines
+8
to
+41
| class PromotedPropertyTypeReflector extends TypeReflector | ||
| { | ||
| public static function create(ReflectionProperty $reflection): self | ||
| { | ||
| return new self($reflection); | ||
| } | ||
|
|
||
| public function __construct(ReflectionProperty $reflection) | ||
| { | ||
| parent::__construct($reflection); | ||
| } | ||
|
|
||
| protected function getDocblock(): string | ||
| { | ||
| return $this->reflection->getDeclaringClass()->getMethod('__construct')->getDocComment(); | ||
| } | ||
|
|
||
| protected function docblockRegex(): string | ||
| { | ||
| $parameterName = $this->reflection->getName(); | ||
| return '/@param\s+([^\s<]+(?:<[^>]*>)?)\s+\$' . preg_quote($parameterName, '/') . '\b/m'; | ||
|
|
||
| } | ||
|
|
||
| protected function getReflectionType(): ?ReflectionType | ||
| { | ||
| return $this->reflection->getType(); | ||
| } | ||
|
|
||
| protected function getAttributes(): array | ||
| { | ||
| return $this->reflection->getAttributes(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Could we just use the PropertyTypeReflector here? Since a promoted property is technically a property. We could in the constructor check if the reflection property is a promoted property and then change getDocblock and docblockRegex. In v3 this problem should already be fixed since we're using PHPstan annotations over there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for promoted properties. The regex may need some tweaking.