Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #43 by converting SecurityTxtCannotVerifySignatureException from a hard error that stops validation into a warning that allows validation to continue. This enables the security.txt file to be validated even when the GPG signature is damaged or cannot be verified.
Key changes:
- New
SecurityTxtSignatureCannotVerifyviolation class to represent damaged signatures as warnings - Exception message format simplified from labeled format to comma-separated format
- Exception handling updated to catch and convert signature verification failures to warnings
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/Violations/SecurityTxtSignatureCannotVerify.php |
New violation class for damaged signatures that cannot be verified |
src/Signature/SecurityTxtSignature.php |
Catches SecurityTxtCannotVerifySignatureException and converts to warning; removes exception from PHPDoc |
src/Signature/Exceptions/SecurityTxtSignatureErrorInfoException.php |
Refactors error message formatting to use comma-separated format; adds public getErrorInfoMessage() method |
src/Parser/SecurityTxtParser.php |
Removes SecurityTxtCannotVerifySignatureException from PHPDoc |
src/Check/SecurityTxtCheckHost.php |
Removes SecurityTxtCannotVerifySignatureException from PHPDoc |
src/Check/SecurityTxtCheckHostCli.php |
Removes SecurityTxtCannotVerifySignatureException from catch block |
tests/Signature/SecurityTxtSignatureTest.phpt |
Updates tests to expect warning instead of exception; updates error message format expectations |
tests/Signature/Providers/SecurityTxtSignatureGnuPgProviderTest.phpt |
Updates error message format expectations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spaze
force-pushed
the
spaze/signature-verify-fail-still-validate
branch
from
94d16d3 to
b2da1e5
Compare
spaze
force-pushed
the
spaze/signature-verify-fail-still-validate
branch
from
b2da1e5 to
917e57b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #43