-
Notifications
You must be signed in to change notification settings - Fork 3
Crypto Algorithms List Properties Description #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Description of the properties of the merged list draft.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things need to be cleared up.
## Id | ||
|
||
* Description: univocal identifier for every cryptographic algorithm. This list provides an identifier per algorithm. | ||
* Values: alphanumeric, where the usage of lower or upper case characters depend on each algorithm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"alphanumeric" means only letters and numbers, so strings like "SHA-512" will not be allowed.
The list already contains blum-goldwasser
(illegal -
) and chacha(salsa)
(illegal parentheses) which have to be changed.
No objection from my side, just making it explicitly known.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in commit 3d67d80
## commonkeySize | ||
|
||
* Description: the detected key size | ||
* Values: bbbb, where bbbb is an integer, provided in bits. More than one value is possible, separated by the operator AND |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When/If this is integrated in the model, this will be transformed into "multiple commonKeySize entries are allowed" (not an arbitrary string with ANDs).
You might consider doing this change now. It's perfectly fine for an independent Crypto Algorithm List, but if any of this will end up in the model, there will be changes.
## specifiedkeySize | ||
|
||
* Description: the default key size or range determined by the authors of the algorithm, standardization or compliance bodies/agencies | ||
* Values: any of these options are valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are the options mutually exclusive or can they be combined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in the commit 3d67d80
* Description: the default key size or range determined by the authors of the algorithm, standardization or compliance bodies/agencies | ||
* Values: any of these options are valid | ||
* bbbb, where bbbb is an integer, provided in bits. More than one value is possible, separated by the operator AND | ||
* bbbb TO cccc, where bbbb and cccc are integers, provided in bits, to express a range |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(applies to all sizes)
Is there a requirement that the integers have to be 4 digits? If not, replace bbbb
and cccc
with <integer>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in the commit 3d67d80
* Asymmetric-key algorithms, commonly known as public-key algorithms, use two related keys (i.e., a key pair) to perform their functions: a public key and a private key. The public key may be known by anyone; the private key should be under the sole control of the entity that “owns” the key pair. Even though the public and private keys of a key pair are related, knowledge of the public key cannot be used to determine the private key. | ||
* Values: "Cryptographic-Hash-Function" , "Symetric-Key-Algorithm" or "Asymmetric-Key-Algorithm" | ||
|
||
Note: the subclasses has been added to the cryptoClass property, separated by a "/" character from the class. This specific way to structure the subclasses is WIP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If "Values" is a fixed set of 3 alternatives, there cannot be subclasses.
The easiest way would be to define something like cryptoSubClass
as a separate string, arbitrary for now, to be defined maybe later.
Otherwise you have to explain here the actual structure of the allowed values.
Co-authored-by: Alexios Zavras (zvr) <[email protected]>
Addressed comments 1, 3 and 4 from @zvr
Description of the properties of the merged list draft. #8