Skip to content

Add Markdown lint#1189

Open
bact wants to merge 6 commits intospdx:developfrom
bact:add-markdown-lint
Open

Add Markdown lint#1189
bact wants to merge 6 commits intospdx:developfrom
bact:add-markdown-lint

Conversation

@bact
Copy link
Collaborator

@bact bact commented Jan 13, 2026

Lint Markdown and make it relatively strict to avoid MkDocs issues. To reduce work of reviewers.

Ignore few rules due to specific use in our model format. For example:

  • MD034 - Bare URL used / We need bare URL in metadata section
  • MD036 - Emphasis used instead of a header / We use *Example* in description
  • MD041 - First line in file should be a top level header / Our first line has to be the license line

This PR also includes few issues reported by Markdownlint, to make the check passes:

  • Remove double blank lines in ExternalIdentifierType
  • Rearrange position of "release notes" in the change log, to avoid duplicated heading

Lint Markdown and make it relatively strict to avoid MkDocs issues.

Ignore few rules due to specific use in our model format. For example:

- MD034 - Bare URL used / We need that in metadata section
- MD036 - Emphasis used instead of a header / We use `*Example*` in description
- MD041 - First line in file should be a top level header / Our file line has to be the license line

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact added the ci Dev workflow and repo management label Jan 13, 2026
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact added this to the milestone-independent milestone Jan 13, 2026
@goneall
Copy link
Member

goneall commented Jan 16, 2026

I like adding this in, but lets merge this in after RC1 release.

Updated the Markdown lint workflow to include its own file in the paths for push and pull request events.

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact requested review from goneall, kestewart and zvr February 11, 2026 12:28
bact added 2 commits February 11, 2026 12:32
- Remove duplicated headings
- Remove double blank line

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact added the documentation Improvements or additions to documentation label Feb 11, 2026
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Since we've done the RC1 release, once we get one more review we can merge

Ping @zvr @kestewart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Dev workflow and repo management documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants