Make DateTime and SemVer patterns more portable#1213
Open
bact wants to merge 2 commits intospdx:developfrom
Open
Make DateTime and SemVer patterns more portable#1213bact wants to merge 2 commits intospdx:developfrom
bact wants to merge 2 commits intospdx:developfrom
Conversation
Make the pattern more defensive/portable. SHACL processor may rely on platform's regex engine and some engine interpret `\d` as any Unicode decimal digit beyond ASCII `0` - `9` characters. Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
goneall
approved these changes
Jan 26, 2026
Collaborator
Author
|
@JPEWdev will this relevant to regex in shacl2code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the patterns more defensive/portable, keep the original semantics.
A SHACL processor may rely on platform's regular expression engine and some engine interpret
\das any Unicode decimal digit, beyond ASCII0-9characters, by default.In those engines,
\dcan match, for example: १ २ ३ ๔ ๕ ๖ ၉Tested with .NET System.Text.RegularExpressions and PyICU (ICU4C).