Add default for getCaseSensitiveId. #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is necessary for campatibility for implementations using the misspelled getCaseInsensitiveId method. Note that if you reversed the default, new implementation will fail since they don't implement the misspelled version. The solution is to have default implementations for both versions. This could, however, cause a stack overflow if no implementation is provided. To avoid this, we use introspection to see if the default is used. Note that this changes the behavior of a missing interface from a compile time error to a run-time error.
|
Collaborator
|
I have looked at the code. Far more sophisticated than I was thought, but very well thought. Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is necessary for compatibility for implementations using the misspelled getCaseSensitiveId method. Note that if you reversed the default, new implementation will fail since they don't implement the misspelled version. The solution is to have default implementations for both versions. This could, however, cause a stack overflow if no implementation is provided. To avoid this, we use introspection to see if the default is used.
Note that this changes the behavior of a missing interface from a compile time error to a run-time error.