feat: implement custom domain removal #1489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scope the unique index on custom_domains.domain to non-deleted rows so that soft-deleted domains don't block re-registration. Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Create new partial index first, then drop old, then rename. This avoids a window with no uniqueness enforcement. Co-Authored-By: Claude Opus 4.5 <[email protected]>
adaam2
force-pushed
the
feat/remove-custom-domain
branch
from
d9f2ab6 to
29ce932
Compare
adaam2
changed the base branch from
main
to
chore/custom-domains-partial-unique-index
- Implement DeleteDomain endpoint (was a no-op stub) - Add CustomDomainDeletionWorkflow to clean up K8s ingress/TLS - Redesign settings UI: replace table with card, add remove button - Show placeholder DNS values until domain input is valid Co-Authored-By: Claude Opus 4.5 <[email protected]>
adaam2
force-pushed
the
feat/remove-custom-domain
branch
from
29ce932 to
a34d51f
Compare
Contributor
|
|
||||||||||||||||
Contributor
|
|
||||||||||||||||
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Set min-height on dialog content to prevent modal resizing as domain input values change. Also fix "Verify" → "Reverify" label. Co-Authored-By: Claude Opus 4.5 <[email protected]>
The delete activity previously read the domain record from the DB, but the record is soft-deleted before the async workflow runs. Now the ingress name and cert secret name are passed through the workflow params so the delete activity doesn't need a DB lookup. Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Use invalidateAllGetDomain SDK helper instead of hardcoded query key - Block on deletion workflow completion before soft-deleting DB record to prevent inconsistent state if the workflow fails Co-Authored-By: Claude Opus 4.5 <[email protected]>
Skip K8s ingress cleanup when IngressName or CertSecretName are NULL in the database, rather than passing empty strings to the workflow. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Base automatically changed from
chore/custom-domains-partial-unique-index
to
main
February 4, 2026 17:00
Collaborator
🚀 Preview Environment (PR #1489)Preview URL: https://pr-1489.dev.getgram.ai
Gram Preview Bot |
disintegrator
approved these changes
Feb 4, 2026
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DeleteDomainAPI endpoint (previously a no-op stub) with K8s ingress cleanup via Temporal workflowmise db:resettask for fully resetting the local databaseDepends on #1488 (migration PR)
Test plan
🤖 Generated with Claude Code