Skip to content

Conversation

mdrazak2001
Copy link
Contributor

@mdrazak2001 mdrazak2001 commented Sep 20, 2025

Adding Filtering methods on add/edit tool screen:

  • enable/ disable all button
  • http method type
  • enabled/disabled filter view

Fixes: #308

Recording 2025-09-23 073746

- disable all
- http method type
@mdrazak2001 mdrazak2001 requested a review from a team as a code owner September 20, 2025 10:20
Copy link

changeset-bot bot commented Sep 20, 2025

⚠️ No Changeset found

Latest commit: 98d239d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 20, 2025

@mdrazak2001 is attempting to deploy a commit to the Speakeasy Team on Vercel.

A member of the Team first needs to authorize it.

cursor[bot]

This comment was marked as outdated.

@mdrazak2001 mdrazak2001 changed the title tool filtering feat: add/edit tool filtering Sep 20, 2025
@mdrazak2001 mdrazak2001 changed the title feat: add/edit tool filtering feat: add/edit tool filtering[wip] Sep 23, 2025
@mdrazak2001 mdrazak2001 changed the title feat: add/edit tool filtering[wip] feat: add/edit tool filtering Sep 23, 2025
];

const enabledFilter = (
<MultiSelect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need to run prettier on this file

{allEnabled ? (
<X className="w-4 h-4" />
) : (
<div className="flex gap-2 justify-end">
Copy link
Contributor

@farazcsk farazcsk Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature!

I think a more common pattern would be a checkbox in the header row inline with the other checkboxes?

Copy link
Contributor Author

@mdrazak2001 mdrazak2001 Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farazcsk : okie, i think thatll be more elegant, but 1 quick qn,
are we planning on a single checkbox? if yes say the checkbox is checked, and some tools are deselected, would the checkbox get unchecked? and to deselect all tools would the user need to do 2 clicks, unchecked(if we assume it gets unchecked on partial tool deslection) -> check(manual) -> uncheck(manual)

Copy link
Contributor

@farazcsk farazcsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice features!

Just some small suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: More add/remove tools filtering and features (AGE-387)

2 participants