-
Notifications
You must be signed in to change notification settings - Fork 12
feat: add/edit tool filtering #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- disable all - http method type
|
@mdrazak2001 is attempting to deploy a commit to the Speakeasy Team on Vercel. A member of the Team first needs to authorize it. |
]; | ||
|
||
const enabledFilter = ( | ||
<MultiSelect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May need to run prettier on this file
{allEnabled ? ( | ||
<X className="w-4 h-4" /> | ||
) : ( | ||
<div className="flex gap-2 justify-end"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice feature!
I think a more common pattern would be a checkbox in the header row inline with the other checkboxes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@farazcsk : okie, i think thatll be more elegant, but 1 quick qn,
are we planning on a single checkbox? if yes say the checkbox is checked, and some tools are deselected, would the checkbox get unchecked? and to deselect all tools would the user need to do 2 clicks, unchecked(if we assume it gets unchecked on partial tool deslection) -> check(manual) -> uncheck(manual)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice features!
Just some small suggestions
Adding Filtering methods on add/edit tool screen:
Fixes: #308