-
Notifications
You must be signed in to change notification settings - Fork 12
feat: gram upload #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gram upload #427
Conversation
🦋 Changeset detectedLatest commit: 5706eed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
87bbf24
to
c489836
Compare
c489836
to
75334df
Compare
75334df
to
c762df4
Compare
c762df4
to
3df22c9
Compare
3df22c9
to
a5662d5
Compare
a5662d5
to
74180fb
Compare
74180fb
to
2a4fbe3
Compare
2a4fbe3
to
c6354ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to show the output DX from gram upload
?
if deployment == nil { | ||
fmt.Println("{}") | ||
return nil | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think so. It’s the state of having no active deployments, which happens after creating a new project, for example. I think it’s OK.
Description
Upload assets to a deployment. Instead of pushing an entire deployment (
gram push
), this command evolves an active deployment with a new asset.Recommend hiding whitespace changes. Apologies for some messy diffs, because fields that used to be private are public now.
Implementation
Introduce
deploy.Workflow
to consolidate push, upload, and status commands.Example