-
Notifications
You must be signed in to change notification settings - Fork 10
fix: prevent race condition panic when unmarshalling YAML with duplicate keys #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📊 Test Coverage ReportCurrent Coverage: Coverage Change: ✅ No change Coverage by Package
📋 Detailed Coverage by Function (click to expand)
Generated by GitHub Actions |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a race condition panic (
reflect: slice index out of range) that occurred when unmarshalling YAML files containing duplicate keys. Multiple goroutines were concurrently writing to the same struct fields.Problem
When YAML maps contained duplicate keys, the concurrent unmarshalling logic in
errgroupwould process all occurrences simultaneously, causing race conditions when setting struct fields.Solution
Added duplicate key detection with a pre-scan approach in two locations:
unmarshalModel()- Pre-scans map keys before concurrent processingunmarshalSequencedMap()- Same pattern for sequenced map typesThe fix:
indicesToSkipmap to properly handle empty string keys (required for JSON Schema Test Suite compatibility)Testing
Added comprehensive tests in
marshaller/duplicate_key_test.gocovering: